-
Notifications
You must be signed in to change notification settings - Fork 295
Activation hooks redesign (reuse hooks component across both minitron and puzzletron) #1022
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
danielkorzekwa
wants to merge
9
commits into
main
Choose a base branch
from
dkorzewa/activation_hooks_redesign_minitron_puzzletron
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
e897d49
Add shared activation hooks infrastructure for minitron and puzzletron
danielkorzekwa b0e3c9e
Add logger dependency for activation hooks
danielkorzekwa 08a4b66
Add a logger and json_dump needed by base_hooks (TODO: both should be…
danielkorzekwa ee51e7b
Fix a broken test due to a missing random seed.
danielkorzekwa fe7aa4b
Logging and robust_json refactoring.
danielkorzekwa 6188e8d
Delete not needed logger and robust_json (moved to modelopt)
danielkorzekwa a4b8958
Change the location for activation hooks from nas..... to prune.impor…
danielkorzekwa 91fa36d
Add a security comment why using torch.load(weight_only=False)
danielkorzekwa 6345290
No need for computing gradients during a loop for activation hooks an…
danielkorzekwa File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| # SPDX-FileCopyrightText: Copyright (c) 2024 NVIDIA CORPORATION & AFFILIATES. All rights reserved. | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
| """Forward hooks for estimating importance scores for pruning.""" | ||
|
|
||
| from modelopt.torch.utils import import_plugin | ||
|
|
||
| from .base_hooks import * | ||
| from .base_hooks_analysis import * | ||
|
|
||
| with import_plugin("megatron_hooks"): | ||
| from .plugins.megatron_hooks import * |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.