Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bugs for multi_latent_attention #1203

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

xqiangx1991
Copy link

  1. The initialization parameters for DotProductAttention and TEDotProductAttention are different. Using DotProductAttention to construct MultiLatentAttention will result in an error.
  2. In the MLASelfAttention module, the dimensions of k_pos_emb and k_no_pe differ in terms of num_attention_heads.torch.cat will result in an error.

Copy link

github-actions bot commented Dec 8, 2024

Marking as stale. No activity in 60 days.

@github-actions github-actions bot added the stale No activity in 60 days on issue or PR label Dec 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale No activity in 60 days on issue or PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant