Test on the new AXLearn version #1595
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR allows us to finally switch from my forked AXLearn version to the main AXLearn 🎉 |
gpupuck
previously approved these changes
Aug 1, 2025
olupton
requested changes
Aug 4, 2025
.github/container/test-axlearn.sh
Outdated
| found_files=$(find . -name "$file" -type f 2>/dev/null) | ||
| if [[ -n "$found_files" ]]; then | ||
| while IFS= read -r found_file; do | ||
| # Handle the ambiguous 'utils_test.py' as a special case. |
There was a problem hiding this comment.
This seems a bit complicated. Why not just list out the paths? It looks like you are just putting axlearn/common in front of them all.
% find . -name utils_test.py -or -name trainer_test.py -or -name input_dispatch_test.py -or -name input_base_test.py -or -name gda_test.py
./axlearn/cli/utils_test.py
./axlearn/common/utils_test.py
./axlearn/common/trainer_test.py
./axlearn/common/input_dispatch_test.py
./axlearn/common/quantized_dot_general/utils_test.py
./axlearn/common/input_base_test.py
./axlearn/common/flash_attention/utils_test.py
./axlearn/common/gda_test.py
./axlearn/cloud/gcp/utils_test.py
./axlearn/cloud/gcp/runners/utils_test.py
./axlearn/cloud/common/utils_test.py
There was a problem hiding this comment.
Can't this code go away now?
There was a problem hiding this comment.
Sorry, updated this now
|
Can this be closed @Steboss ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.