Skip to content

Add missing port for ssh connection for upstream T5x test #1075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add missing port for ssh connection for upstream T5x test #1075

wants to merge 1 commit into from

Conversation

DwarKapex
Copy link
Contributor

Add missing ssh port for upstream T5x test

terrykong
terrykong approved these changes Oct 2, 2024
View reviewed changes
Copy link
Contributor

@terrykong terrykong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - assuming tests pass

yhtang
yhtang requested changes Oct 10, 2024
View reviewed changes
Copy link
Collaborator

@yhtang yhtang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's encode the port as a secret. Otherwise, it is visible to the outside world.

@yhtang
Copy link
Collaborator

yhtang commented Oct 10, 2024

I just made this proposal to address the SSH port security issue for good: #1093
@DwarKapex

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yhtang yhtang yhtang requested changes

@terrykong terrykong terrykong approved these changes

@olupton olupton Awaiting requested review from olupton

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@DwarKapex @yhtang @terrykong