Conversation
881bf66 to
3c36b1f
Compare
9061629 to
5898c35
Compare
3664292 to
d039b8b
Compare
|
!build --dev |
…el for setuptools
|
!build --dev |
1 similar comment
|
!build --dev |
…PEP517 doesn't support command line args for setup.py
|
!build --dev |
|
!build --dev |
|
!test --dev |
|
!test --dev |
| 'tools/linter/adapters/pip_init.py', | ||
| '--dry-run={{DRYRUN}}', | ||
| 'flake8==6.0.0', | ||
| 'flake8==6.1.0', |
There was a problem hiding this comment.
Upgraded to fix false positive E231 error in python/nvfuser/__init__.py strings.
6d22a4a to
3fa7885
Compare
|
!test --dev |
jjsjann123
left a comment
There was a problem hiding this comment.
One other question I have is, what's the reason of still keeping pieces in ./setup.py, instead of moving all the logic into ./python/setup.py? Are we planning future PRs to keep moving things, since we are going to remove root directory setup.py eventually.
| tools/pip-install-things.sh & | ||
| source tools/setup-env.sh | ||
| wait | ||
| cd python |
There was a problem hiding this comment.
nitpick, is there any reason that we are not jumping to the new build command in CI yet?
There was a problem hiding this comment.
pip install didn't work for clang-tidy, so I reverted to the old way.
Traceback (most recent call last):
File "/opt/hostedtoolcache/Python/3.10.17/x64/lib/python3.10/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 389, in <module>
main()
File "/opt/hostedtoolcache/Python/3.10.17/x64/lib/python3.10/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 373, in main
json_out["return_val"] = hook(**hook_input["kwargs"])
File "/opt/hostedtoolcache/Python/3.10.17/x64/lib/python3.10/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 209, in prepare_metadata_for_build_editable
return hook(metadata_directory, config_settings)
File "/opt/hostedtoolcache/Python/3.10.17/x64/lib/python3.10/site-packages/setuptools/build_meta.py", line 450, in prepare_metadata_for_build_editable
return self.prepare_metadata_for_build_wheel(
File "/opt/hostedtoolcache/Python/3.10.17/x64/lib/python3.10/site-packages/setuptools/build_meta.py", line 379, in prepare_metadata_for_build_wheel
self._bubble_up_info_directory(metadata_directory, ".egg-info")
File "/opt/hostedtoolcache/Python/3.10.17/x64/lib/python3.10/site-packages/setuptools/build_meta.py", line 350, in _bubble_up_info_directory
info_dir = self._find_info_directory(metadata_directory, suffix)
File "/opt/hostedtoolcache/Python/3.10.17/x64/lib/python3.10/site-packages/setuptools/build_meta.py", line 361, in _find_info_directory
assert len(candidates) == 1, f"Multiple {suffix} directories found"
AssertionError: Multiple .egg-info directories found
|
I think the purpose of keeping the root path |
|
!test --dev |
61a6c62 to
5f83d98
Compare
|
!test |
|
It seems that https://github.com/NVIDIA/Fuser/tree/5c0fb061ade125ba9e52ebef9226c06e74ff3836/python/tools is also installed as Lines 548 to 553 in 5c0fb06 |
This PR updates the build to use a
pyproject.tomland isolates the python bindings intopythondirectory.Install From Source:
Details
csrc/python_frontendandnvfusertopython.tools/gen_nvfuser_version.pyandtools/memory.pytopython.setup.pyinpython. This is the new primarysetup.py.setup.pyin root directory.Changes to argument passing to
root/setup.pyandroot/python/setup.pypython/utils.pyhas the common utilities betweenroot/setup.pyandroot/python/setup.pyargparseto create adataclassconfiguration.argparsecreates a defaultdataclassif no arguments are not provided in the command line.NVFUSER_BUILD_ENV_VARSthen overrides the values in thedataclass.root/setup.pyonly supports command-line arguments.