Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NoOpScheduler::computeHeuristics should return NoOpHeuristic #3670

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

NoOpScheduler::computeHeuristics should return NoOpHeuristic #3670

wants to merge 1 commit into from

Conversation

jjsjann123
Copy link
Collaborator

No description provided.

@jjsjann123
Copy link
Collaborator Author

!test

jjsjann123
jjsjann123 commented Jan 3, 2025
View reviewed changes
benchmarks/cpp/utils.cpp
const auto& compile_log = executor_cache->getMostRecentExecutorInfo();
auto params = toString(compile_log.params);
auto lparams = toString(
compile_log.fusion_executor->as<KernelExecutor>()->lastLaunchParams());
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only compute these when needed.

i.e. if segmentation happens with NoOp segment, the toString method above would fail.

@jjsjann123 jjsjann123 mentioned this pull request Jan 3, 2025
Open
@naoyam
Copy link
Collaborator

naoyam commented Jan 6, 2025

I'm not sure why NoOpHeuristic needs to be returned? Looks like it's no longer used. Isn't it just that the util function of the old benchmarks would need to be updated?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jjsjann123 @naoyam