Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move scheduling op bindings to a separate file #3639

Merged
merged 3 commits into from
Jan 2, 2025
Merged

Move scheduling op bindings to a separate file #3639

merged 3 commits into from
Jan 2, 2025

Conversation

wujingyue
Copy link
Collaborator

python_bindings.cpp grows too large.

@wujingyue
Copy link
Collaborator Author

!test

rdspring1
rdspring1 reviewed Dec 24, 2024
View reviewed changes
Copy link
Collaborator

@rdspring1 rdspring1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Any opinion on changing FusionDefinition::SchedOperators to FusionDefinition::Schedule in the future. I think I prefer a single full word to abbreviation.

csrc/python_frontend/sched_op_bindings.cpp Outdated Show resolved Hide resolved
@wujingyue
Copy link
Collaborator Author

Any opinion on changing FusionDefinition::SchedOperators to FusionDefinition::Schedule in the future. I think I prefer a single full word to abbreviation.

SGTM

@wujingyue wujingyue requested a review from rdspring1 December 24, 2024 01:27
@wujingyue
Copy link
Collaborator Author

!test

@wujingyue wujingyue merged commit 5ed5dad into main Jan 2, 2025
48 checks passed
@wujingyue wujingyue deleted the wjy/split branch January 2, 2025 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rdspring1 rdspring1 rdspring1 approved these changes

@jjsjann123 jjsjann123 Awaiting requested review from jjsjann123

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wujingyue @rdspring1