[wgmma] Insert commit_group and wait_group after mma_async #3573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
!test |
|
@jacobhinkle I ran into #3561 when working with register sharing and warp specialization. I wonder if I can use this. |
rdspring1
reviewed
Jan 3, 2025
There was a problem hiding this comment.
There can be multiple wgmma operations per circular buffer stage. e.g., when the k dimension is a multiple of mma macro.
It should be safe to wait for all operations per stage.
I made the following change in WarAsyncWaitInserter.
https://github.com/NVIDIA/Fuser/pull/3616/files#diff-49bea61a8cde014ec0396c89d0654813136e0bd3ffe8b3a5974ee9ccf3a5fbb8R1010-R1024
It didn't any performance difference. 🤷🏼
| auto* commit = IrBuilder::create<kir::AsyncCommit>(AsyncOpType::WgMma); | ||
| auto* wait = IrBuilder::create<kir::AsyncWait>( | ||
| AsyncOpType::WgMma, | ||
| /*keep_stages=*/cb_opts.stage - cb_opts.prefetch - 1); |
There was a problem hiding this comment.
If cb_opts.stage - cb_opts.prefetch == 0, then the keep_stages will be -1, which is invalid.
Suggested change
| /*keep_stages=*/cb_opts.stage - cb_opts.prefetch - 1); | |
| std::min(0LL, /*keep_stages=*/cb_opts.stage - cb_opts.prefetch - 1)); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3561.