Add info about wds2idx.py versions used to generate WDS data #77
Conversation
| with the WebDataset index file versions. | ||
|
|
||
| Versions of wds2idx.py file used to generate particular .idx files | ||
| v1.1 - aba138bf09d5d1befe96d025220a93531ab9c49f |
There was a problem hiding this comment.
Is this a sha of the script?
There was a problem hiding this comment.
Apparently not, it is a commit sha (NVIDIA/DALI@aba138b).
The other is also a commit sha, however not related to wds2idx.py file (NVIDIA/DALI@59f1ad9).
I guess we should decide what to do with this PR. I'd see two possible choices:
- Fill the REAMDE with
wds2idx.pyfile sha's and merge the PR, - Close the PR.
@JanuszL , since you were the original requester (#75 (review)), do you have any preference which path should we take?
There was a problem hiding this comment.
As this small change I would finalize it. so Fill the REAMDE with wds2idx.py file sha's and merge the PR,. Can you also a comment what this value is about in the readme.
Signed-off-by: szalpal <[email protected]>
Signed-off-by: szalpal <[email protected]>
Signed-off-by: Michał Szołucha <[email protected]>
| Should you need to generate .idx files for an older DALI version, | ||
| please use these versions of the wds2idx.py script. | ||
|
|
||
| v1.1 - 87b247f0a8d4e7af389278a2c8a360e1 |
There was a problem hiding this comment.
I'm not sure if MD5 is helpful for versioning. It does answer whether the version I have matches the expected one, but if I need to roll back to an older version, it's impossible to easily identify which version to select based on the given hash.
Signed-off-by: Michał Szołucha <[email protected]>
3 participants
Followup for #75 (#75 (review))
Signed-off-by: szalpal [email protected]