added Agno integration #36

wenqiglantz · 2025-03-26T18:11:00Z

Changes included in this PR:

added Agno package
added agno_personal_finance workflow

mdemoret-nv · 2025-03-26T19:35:31Z

mdemoret-nv · 2025-03-26T19:36:24Z

@wenqiglantz Before we can get this merged, we will need the DCO check to pass. You can find more info about this here: https://github.com/NVIDIA/AgentIQ/pull/36/checks?check_run_id=39465660296

Signed-off-by: Wenqi Glantz <[email protected]>

dnandakumar-nv

Thank you for your PR, @wenqiglantz ! The additions look great and I'm sure adding support for the Agno package will be valuable. I did have a few comments during the review that I'm hoping we can address to get this merged.

Additionally, I think increased unit testing in the following two areas would be beneficial:

Unit tests in the agentiq_agno package for the tool and llm wrappers to ensure they build correctly in a few different cases. You can find an example of tests here and here
Unit tests for the agno_callback_handler to ensure events are being captured and traced correctly. You can find examples here.

examples/agno_personal_finance/src/agno_personal_finance/agno_personal_finance_function.py

src/aiq/profiler/callbacks/agno_callback_handler.py

Signed-off-by: Wenqi Glantz <[email protected]>

copy-pr-bot · 2025-04-01T18:35:01Z

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

Signed-off-by: Wenqi Glantz <[email protected]>

dnandakumar-nv · 2025-04-02T16:29:21Z

/ok to test

dnandakumar-nv

Changes look good to me

dnandakumar-nv · 2025-04-02T16:34:25Z

/ok to test

dnandakumar-nv

@wenqiglantz thanks for your changes! The code looks good to me now, but we need the CI to pass before a merge into the repo. Looks like some of the CI is failing due to the lack of copyright headers:

https://github.com/NVIDIA/AgentIQ/actions/runs/14224833050/job/39861721846?pr=36

Signed-off-by: Wenqi Glantz <[email protected]>

… develop

dnandakumar-nv · 2025-04-02T16:55:49Z

/ok to test

Signed-off-by: Wenqi Glantz <[email protected]>

dnandakumar-nv · 2025-04-02T19:44:11Z

/ok to test

Signed-off-by: Wenqi Glantz <[email protected]>

dnandakumar-nv · 2025-04-03T20:32:03Z

/ok to test

ci/scripts/github/tests.sh

examples/agno_personal_finance/tests/test_agno_personal_finance_workflow.py

Signed-off-by: Wenqi Glantz <[email protected]>

ci/scripts/github/tests.sh

Signed-off-by: Wenqi Glantz <[email protected]>

dnandakumar-nv · 2025-04-07T16:49:06Z

/ok to test

dnandakumar-nv

This is looking almost ready! Just a couple minor comments. Thanks for your patience!

ci/vale/styles/config/vocabularies/aiq/accept.txt

examples/agno_personal_finance/src/agno_personal_finance/agno_personal_finance_function.py

Signed-off-by: Wenqi Glantz <[email protected]>

dnandakumar-nv · 2025-04-07T17:55:29Z

/ok to test

dnandakumar-nv · 2025-04-16T15:20:33Z

@wenqiglantz looks like we've got a merge conflict. Ostensibly because the framework wrappers decorator has now moved to aiq.profiler.decorators. Would you mind resolving the conflict?

dnandakumar-nv

Looks good to me!

dnandakumar-nv · 2025-04-16T18:19:14Z

/ok to test 00221bd

examples/agno_personal_finance/pyproject.toml

pyproject.toml

examples/agno_personal_finance/tests/test_agno_personal_finance_workflow.py

Signed-off-by: Wenqi Glantz <[email protected]>

dnandakumar-nv

LGTM

dnandakumar-nv · 2025-04-16T20:12:40Z

/ok to test

copy-pr-bot · 2025-04-16T20:12:43Z

/ok to test

@dnandakumar-nv, there was an error processing your request: E1

See the following link for more information: https://docs.gha-runners.nvidia.com/cpr/e/1/

dnandakumar-nv · 2025-04-16T20:13:04Z

/ok to test fd7b093

dnandakumar-nv · 2025-04-16T20:50:06Z

/merge

mdemoret-nv requested a review from dnandakumar-nv March 26, 2025 19:35

added Agno integration

63a3764

Signed-off-by: Wenqi Glantz <[email protected]>

wenqiglantz force-pushed the develop branch from 3f549fb to 63a3764 Compare March 26, 2025 19:39

updated llm.py in Agno package

cf4a4d9

Signed-off-by: Wenqi Glantz <[email protected]>

dnandakumar-nv requested changes Mar 31, 2025

View reviewed changes

dnandakumar-nv added enhancement New feature or request non-breaking Non-breaking change improvement Improvement to existing functionality and removed enhancement New feature or request labels Mar 31, 2025

wenqiglantz added 3 commits April 1, 2025 13:20

fixes per review comments

d0cdbb0

Signed-off-by: Wenqi Glantz <[email protected]>

fixes per review comments

cb2adeb

Signed-off-by: Wenqi Glantz <[email protected]>

fixes per review comments

6ffe97f

Signed-off-by: Wenqi Glantz <[email protected]>

wenqiglantz requested a review from a team as a code owner April 1, 2025 18:34

fixes per review comments

5940cd9

Signed-off-by: Wenqi Glantz <[email protected]>

wenqiglantz requested a review from dnandakumar-nv April 2, 2025 15:56

Merge branch 'develop' into develop

567d163

dnandakumar-nv approved these changes Apr 2, 2025

View reviewed changes

dnandakumar-nv requested changes Apr 2, 2025

View reviewed changes

wenqiglantz added 2 commits April 2, 2025 12:44

fix pylint issue

4affa90

Signed-off-by: Wenqi Glantz <[email protected]>

Merge branch 'develop' of https://github.com/wenqiglantz/AgentIQ into…

e8b40b6

… develop

wenqiglantz added 2 commits April 2, 2025 14:26

fix CI check warning

54e788a

Signed-off-by: Wenqi Glantz <[email protected]>

fix CI check warning

2eb6ea7

Signed-off-by: Wenqi Glantz <[email protected]>

fix CI error

8573853

Signed-off-by: Wenqi Glantz <[email protected]>

fix CI error

aae0971

Signed-off-by: Wenqi Glantz <[email protected]>

wenqiglantz requested a review from dnandakumar-nv April 3, 2025 01:10

dnandakumar-nv requested changes Apr 3, 2025

View reviewed changes

ci/scripts/github/tests.sh Outdated Show resolved Hide resolved

examples/agno_personal_finance/tests/test_agno_personal_finance_workflow.py Outdated Show resolved Hide resolved

wenqiglantz added 5 commits April 4, 2025 13:35

Merge remote-tracking branch 'upstream/develop' into develop

d7d8b2a

fix unit tests

a98fda5

Signed-off-by: Wenqi Glantz <[email protected]>

Merge remote-tracking branch 'upstream/develop' into develop

65e3d05

added kwargs in accept.txt

87e727f

Signed-off-by: Wenqi Glantz <[email protected]>

updated tests

70956b8

Signed-off-by: Wenqi Glantz <[email protected]>

dnandakumar-nv reviewed Apr 7, 2025

View reviewed changes

ci/scripts/github/tests.sh Outdated Show resolved Hide resolved

wenqiglantz added 2 commits April 7, 2025 11:08

updated uv.lock

395100a

Signed-off-by: Wenqi Glantz <[email protected]>

updated tests

fcf4814

Signed-off-by: Wenqi Glantz <[email protected]>

wenqiglantz requested a review from dnandakumar-nv April 7, 2025 17:19

dnandakumar-nv requested changes Apr 7, 2025

View reviewed changes

ci/vale/styles/config/vocabularies/aiq/accept.txt Outdated Show resolved Hide resolved

examples/agno_personal_finance/src/agno_personal_finance/agno_personal_finance_function.py Outdated Show resolved Hide resolved

updates per review comments

6fc9b2a

Signed-off-by: Wenqi Glantz <[email protected]>

wenqiglantz requested a review from dnandakumar-nv April 7, 2025 18:02

Merge remote-tracking branch 'upstream/develop' into develop

00221bd

dnandakumar-nv approved these changes Apr 16, 2025

View reviewed changes

dnandakumar-nv requested changes Apr 16, 2025

View reviewed changes

examples/agno_personal_finance/pyproject.toml Outdated Show resolved Hide resolved

pyproject.toml Outdated Show resolved Hide resolved

examples/agno_personal_finance/tests/test_agno_personal_finance_workflow.py Outdated Show resolved Hide resolved

renamed workflow to aiq_agno_personal_finance

fd7b093

Signed-off-by: Wenqi Glantz <[email protected]>

dnandakumar-nv approved these changes Apr 16, 2025

View reviewed changes

rapids-bot bot merged commit a8a2a74 into NVIDIA:develop Apr 16, 2025
10 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

added Agno integration #36

added Agno integration #36

wenqiglantz commented Mar 26, 2025

mdemoret-nv commented Mar 26, 2025

mdemoret-nv commented Mar 26, 2025

dnandakumar-nv left a comment

copy-pr-bot bot commented Apr 1, 2025

dnandakumar-nv commented Apr 2, 2025

dnandakumar-nv left a comment

dnandakumar-nv commented Apr 2, 2025

dnandakumar-nv left a comment

dnandakumar-nv commented Apr 2, 2025

dnandakumar-nv commented Apr 2, 2025

dnandakumar-nv commented Apr 3, 2025

dnandakumar-nv commented Apr 7, 2025

dnandakumar-nv left a comment

dnandakumar-nv commented Apr 7, 2025

dnandakumar-nv commented Apr 16, 2025

dnandakumar-nv left a comment

dnandakumar-nv commented Apr 16, 2025

dnandakumar-nv left a comment

dnandakumar-nv commented Apr 16, 2025

copy-pr-bot bot commented Apr 16, 2025

dnandakumar-nv commented Apr 16, 2025

dnandakumar-nv commented Apr 16, 2025

added Agno integration #36

added Agno integration #36

Conversation

wenqiglantz commented Mar 26, 2025

mdemoret-nv commented Mar 26, 2025

mdemoret-nv commented Mar 26, 2025

dnandakumar-nv left a comment

Choose a reason for hiding this comment

copy-pr-bot bot commented Apr 1, 2025

dnandakumar-nv commented Apr 2, 2025

dnandakumar-nv left a comment

Choose a reason for hiding this comment

dnandakumar-nv commented Apr 2, 2025

dnandakumar-nv left a comment

Choose a reason for hiding this comment

dnandakumar-nv commented Apr 2, 2025

dnandakumar-nv commented Apr 2, 2025

dnandakumar-nv commented Apr 3, 2025

dnandakumar-nv commented Apr 7, 2025

dnandakumar-nv left a comment

Choose a reason for hiding this comment

dnandakumar-nv commented Apr 7, 2025

dnandakumar-nv commented Apr 16, 2025

dnandakumar-nv left a comment

Choose a reason for hiding this comment

dnandakumar-nv commented Apr 16, 2025

dnandakumar-nv left a comment

Choose a reason for hiding this comment

dnandakumar-nv commented Apr 16, 2025

copy-pr-bot bot commented Apr 16, 2025

dnandakumar-nv commented Apr 16, 2025

dnandakumar-nv commented Apr 16, 2025