Added user data field to draw item #39
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows extension of the
donut::render::DrawItemstructure via a user datavoid*.My use case for this is I have a mesh instance with multiple representations, and I want to select the representation I use in the draw strategy. The render pass can then recover the desired representation from the draw item keeping the scene and renderer decoupled. However, without DrawItem being polymorphic, there is no safe way to extend DrawItem in my code via inheritance.
I saw packaging user data inside a
void*to be a more general purpose solution and imagine it could be generally useful to implementations of more complex render passes or scene content that still want to make use of the draw strategy interface.