refactor(studio): make the fileset start selection a discriminated union - #1020
Open
steramae-nvidia wants to merge 1 commit into
Open
refactor(studio): make the fileset start selection a discriminated union#1020steramae-nvidia wants to merge 1 commit into
steramae-nvidia wants to merge 1 commit into
Conversation
onContinue took (optionId, templateId?), which could not carry a payload per option without growing more optional arguments. Replace it with a StartSelection union so each option's payload travels with its own case. The Continue footer now renders as soon as an option is picked and disables itself with a hint, rather than appearing only once the choice is complete — previously the button materialized with no explanation of what was missing. Signed-off-by: Sean Teramae <steramae@nvidia.com>
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (4)
📝 WalkthroughWalkthroughChangesFileset start selection flow
Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
CreateFilesetStart'sonContinuetook(optionId, templateId?), which can't carry a payload per option without accumulating more optional arguments. Replaced with aStartSelectiondiscriminated union so each start option's payload travels inside its own case, andNewDataDesignerJobRouteswitches on it exhaustively.Also changes the Continue footer: it now appears as soon as an option is picked and disables itself with a hint ("Pick a recipe to continue."), instead of materializing only once the choice was already complete. Previously the button simply popped into existence with no indication of what was missing.
Why
PR 1 of 3 in a stack that adds the "Describe with AI" start option. This one is purely the contract change — the
aitile staysenabled: falseand no new UI ships. Isolating it means the footer UX change (which is visible on the template path today) gets reviewed on its own rather than buried in a 1000-line feature diff.Stack
steramae/dd-ai-generation-hook— generation/validation/repair hooksteramae/dd-ai-start-option— the panel, and flipping the tile onTesting
pnpm --filter nemo-studio-ui typecheck— cleanpnpm --filter nemo-studio-ui test src/components/CreateFilesetStart/index.test.tsx— 7 passing🤖 Generated with Claude Code
Summary by CodeRabbit
New Features
Bug Fixes