docs: add optimizer docs hidden from docs build - #1014
Open
jeremysilva1098 wants to merge 2 commits into
Open
Conversation
Signed-off-by: Jeremy Silva <jesilva@nvidia.com>
Contributor
Contributor
📝 WalkthroughWalkthroughAdds a comprehensive Insight-Driven Optimization guide and navigation entries for gated and latest documentation versions. ChangesInsight-Driven Optimization documentation
Possibly related PRs
Suggested labels: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Contributor
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/agents/insight-driven-optimization.mdx`:
- Around line 356-357: Update both Studio links in the optimization setup
documentation to construct their URLs from the exported NMP_BASE_URL and
WORKSPACE values instead of hard-coded localhost:8080 and default values, so
they work for remote deployments and non-default workspaces.
- Around line 348-353: Update the “Confirm it worked” section near the API curl
command to distinguish persistence targets by workflow: for profile mode,
instruct users to verify entries in .nemo-optimizer/insights.yaml, and for API
mode, retain the API query command. Ensure the confirmation guidance reflects
the optimizer.yaml discovery behavior described earlier.
- Around line 348-353: Update the Insights API curl example under “Confirm it
worked” to include the Bearer Authorization header using NMP_ACCESS_TOKEN and
the --fail-with-body option, while preserving the existing URL and query
parameters.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 3e654248-c341-4a48-9d89-6cdf5fc63dc2
⛔ Files ignored due to path filters (2)
docs/agents/_images/optimizer-experiment-comparison.pngis excluded by!**/*.pngdocs/agents/_images/optimizer-insight-detail.pngis excluded by!**/*.png
📒 Files selected for processing (3)
docs/agents/insight-driven-optimization.mdxdocs/fern/gated-nav.ymldocs/fern/versions/latest.yml
Contributor
|
nicot
approved these changes
Jul 31, 2026
The two PNGs were the only binary files in the diff, and pre-commit's stash rollback in the lint-merge-conflict step fails to re-apply a binary patch over the working-tree churn left by the earlier regenerating lints. The Studio URLs in the text still point readers at both views. Signed-off-by: Jeremy Silva <jesilva@nvidia.com>
jeremysilva1098
enabled auto-merge
July 31, 2026 22:57
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Jul 31, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Jul 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit