Easymagpie ZeroShot disabling option using speaker encoder#15639
Easymagpie ZeroShot disabling option using speaker encoder#15639paarthneekhara wants to merge 12 commits into
Conversation
paarthneekhara
force-pushed
the
easymagpie_zeroshotdisable
branch
from
6cb30a9 to
e1c1943
Compare
Signed-off-by: paarthneekhara <paarthneekhara@users.noreply.github.com>
Signed-off-by: Paarth Neekhara <paarth.n@gmail.com>
…a/NeMo into easymagpie_zeroshotdisable
| speaker_encoder_cfg = dict(speaker_encoder_cfg) | ||
| speaker_encoder_cfg.pop('router_load_balancing_loss_coeff', None) | ||
| speaker_encoder_cfg.pop('router_z_loss_coeff', None) |
There was a problem hiding this comment.
Why do you expect the context_encoder to have these parameters related to MoE?
There was a problem hiding this comment.
Let's raise an Exception if use_moe is true. And let's log a warning if we detect these parameters intead of popping them from the dictionary. Something like we do not recommend using moe for the context encoder
There was a problem hiding this comment.
Let's raise NeMoBaseException instead of Exception or create another more appropriate one
Signed-off-by: Paarth Neekhara <paarth.n@gmail.com>
blisc
left a comment
blisc
left a comment
There was a problem hiding this comment.
Can you make sure tests run and pass?
| speaker_encoder_cfg = dict(speaker_encoder_cfg) | ||
| speaker_encoder_cfg.pop('router_load_balancing_loss_coeff', None) | ||
| speaker_encoder_cfg.pop('router_z_loss_coeff', None) |
There was a problem hiding this comment.
Let's raise NeMoBaseException instead of Exception or create another more appropriate one
|
Caution Review failedAn error occurred during the review process. Please try again later. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Comment |
Signed-off-by: Paarth Neekhara <paarth.n@gmail.com>
|
/ok to test 1090a8f |
Signed-off-by: Paarth Neekhara <paarth.n@gmail.com>
2 participants
No description provided.