Isolation tests plugin #14904
Open
Isolation tests plugin #14904
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Eli-Siegel-nvidia <[email protected]>
bdubauski
reviewed
Oct 11, 2025
| parser.add_argument( | ||
| "--isolation_noise_pairs", | ||
| type=int, | ||
| help="Container image to use for isolation test", |
There was a problem hiding this comment.
help needs to be updated to explain noise pairs
bdubauski
reviewed
Oct 11, 2025
| required=False, | ||
| ) | ||
|
|
||
| parser.add_argument( |
There was a problem hiding this comment.
Are --isolation_xxx arguments all required when user sets --enable_isolation or are they all truly optional?
bdubauski
reviewed
Oct 11, 2025
| # Step 3: Run the noise job | ||
| mkdir -p {job_dir}/noise | ||
| echo "Launching noise in the background" | ||
| NUMBER_OF_PAIRS=$(($NUM_OF_NOISE_NODES * 4)) # we have 8 GPUS per node, and we want to split to pairs |
There was a problem hiding this comment.
8 GPUs per node is only true for h100 nodes. B200, GB200, GB300 nodes usually have 4 GPUs per node
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
The
Update branchbutton must only be pressed in very rare occassions.An outdated branch is never blocking the merge of a PR.
Please reach out to the automation team before pressing that button.
What does this PR do ?
This PR adds possibility to run performance benchmarks with noisy neighbors to check the isolation of the network.
Collection: [Note which collection this PR will affect]
Changelog
Usage
In order to run the isolation you should add
--isolationarg to the run script.Currently it's added only to nemotron-h.
# Add a code snippet demonstrating how to use thisGitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information