Skip to content

feat(server): allow tool calls outside passthrough mode without dialog flows#2188

Open
christinaexyou wants to merge 2 commits into
NVIDIA-NeMo:pouyanpi/improve-generate-colangfrom
christinaexyou:pouyanpi/improve-generate-colang
Open

feat(server): allow tool calls outside passthrough mode without dialog flows#2188
christinaexyou wants to merge 2 commits into
NVIDIA-NeMo:pouyanpi/improve-generate-colangfrom
christinaexyou:pouyanpi/improve-generate-colang

Conversation

@christinaexyou

Copy link
Copy Markdown
Contributor

… flows

Description

Tool calls were previously gated on passthrough mode. They are now allowed
in any config as long as no dialog flows are defined (user_messages or
single_call dialog rails). Streaming requests still reject tools/tool_choice/
parallel_tool_calls. We explicitly reject tool call requests if dialog flows or streaming is enabled in the config.

Related Issue(s)

Verification

AI Assistance

  • No AI tools were used.
  • AI tools were used; a human reviewed and can explain every change (tool: ___).

Checklist

  • I've read the CONTRIBUTING guidelines.
  • This PR links to a triaged issue assigned to me.
  • My PR title follows the project commit convention.
  • I've updated the documentation if applicable.
  • I've added tests if applicable.
  • I've noted any verification beyond CI and any checks I couldn't run.
  • I did not update generated changelog files manually.
  • I addressed all CodeRabbit, Greptile, and other review comments, or replied with why no change is needed.
  • @mentions of the person or team responsible for reviewing proposed changes.

@github-actions github-actions Bot added status: needs triage New issues that have not yet been reviewed or categorized. size: L needs: signing labels Jul 17, 2026
@github-actions

github-actions Bot commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

PR merge guidance

@christinaexyou thanks for the PR. GitHub is currently blocking merge for one or more repository requirements:

  • 2 commits do not have a verified signature (ee0bf26, 9c8f260). Please sign the commits and force-push the updated branch.

Relevant guide:

… flows

Signed-off-by: Christina Xu <chrxu@redhat.com>
…are configured

Signed-off-by: Christina Xu <chrxu@redhat.com>
@christinaexyou
christinaexyou force-pushed the pouyanpi/improve-generate-colang branch from aff6a45 to 9c8f260 Compare July 17, 2026 17:44
@Pouyanpi Pouyanpi changed the title fix(server): allow tool calls outside passthrough mode without dialog… feat(server): allow tool calls outside passthrough mode without dialog flows Jul 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs: signing size: L status: needs triage New issues that have not yet been reviewed or categorized.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant