Skip to content

fix: re-enable megatronfsdp tests #1134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
akoumpa wants to merge 9 commits into
base: main
Choose a base branch
from
Draft

fix: re-enable megatronfsdp tests #1134

akoumpa wants to merge 9 commits into from

Conversation

@akoumpa
Copy link
Contributor

@akoumpa akoumpa commented Jan 29, 2026

What does this PR do ?

Add a one line overview of what this PR aims to accomplish.

Changelog

  • Add specific line by line info of high level changes in this PR.

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?

If you haven't finished some of the above items you can still open "Draft" PR.

Additional Information

  • Related to # (issue)

@akoumpa
re-enable tests
7999785 
Signed-off-by: Alexandros Koumparoulis <[email protected]>
@copy-pr-bot
Copy link

copy-pr-bot bot commented Jan 29, 2026

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@akoumpa akoumpa linked an issue Jan 29, 2026 that may be closed by this pull request
MegatronFSDP CI TP tests failing #478
Open
@akoumpa
fix
187114b 
Signed-off-by: Alexandros Koumparoulis <[email protected]>
@akoumpa
fix
0d131f8 
Signed-off-by: Alexandros Koumparoulis <[email protected]>
@akoumpa
revert
498ae4c 
Signed-off-by: Alexandros Koumparoulis <[email protected]>
@akoumpa
Copy link
Contributor Author

akoumpa commented Jan 29, 2026

/ok to test 498ae4c

@akoumpa
fix
f888ddc 
Signed-off-by: Alexandros Koumparoulis <[email protected]>
@akoumpa
fix
52e118b 
Signed-off-by: Alexandros Koumparoulis <[email protected]>
@akoumpa
Copy link
Contributor Author

akoumpa commented Jan 29, 2026

/ok to test 52e118b

@akoumpa
fix
bd66859 
Signed-off-by: Alexandros Koumparoulis <[email protected]>
@akoumpa
Copy link
Contributor Author

akoumpa commented Jan 29, 2026

/ok to test bd66859

@akoumpa
add test
45b907c 
Signed-off-by: Alexandros Koumparoulis <[email protected]>
@akoumpa
Copy link
Contributor Author

akoumpa commented Feb 1, 2026

/ok to test 45b907c

@akoumpa akoumpa changed the title fix: re-enable megatronfsdp fix: re-enable megatronfsdp tests Feb 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@HuiyingLi HuiyingLi Awaiting requested review from HuiyingLi HuiyingLi will be requested when the pull request is marked ready for review HuiyingLi is a code owner

@adil-a adil-a Awaiting requested review from adil-a adil-a will be requested when the pull request is marked ready for review adil-a is a code owner

@hemildesai hemildesai Awaiting requested review from hemildesai hemildesai will be requested when the pull request is marked ready for review hemildesai is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

MegatronFSDP CI TP tests failing

2 participants

@akoumpa