-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Depthai support #116
Open
Serafadam
wants to merge
1
commit into
NVIDIA-ISAAC-ROS:main
Choose a base branch
from
Serafadam:depthai_support
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add Depthai support #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi. I was testing out your PR and I'm running into the issue where the calculated baseline of the images for the VSLAM algorithm is 0 and it's throwing an error. Have you seen this before?
|
Hi @mstiehm-NF, thanks for the notification, I'll investigate it next week, I assume that some things changed in the latest release of VSLAM library |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This one adds:
One issue that seems to appear is that VSLAM node outputs following warnings:
[visual_slam_node]: Delta between current and previous frame [44.023430] is above threshold [22.000000]
Although camera FPS is ~90 according to
ros2 topic echo
, not sure what could be the issue is. I'd be happy to improve the integration in the near future.Related PR: Add DepthAI support isaac_ros_common#92