Repository navigation
Fix ball accelerating and flying off the field - #37
Merged
Merged
Conversation
The ball body sat at the world origin with its geoms offset 1.38 m, so its free joint rotated the ball about a point 1.38 m away. Any roll faster than ~1.5 m/s diverged numerically (a 2 m/s roll reached >10 km/s). Centre the ball body on its geoms at the rest point. Keyframes zero-pad the ball's free joint, which used to land it correctly only because of the offset, so SimCore::place_ball now re-places the ball (scene rest point, or the centre mark in a game) after every keyframe reset. check_model.py does the same after its keyframe reset. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
papazed
pushed a commit
to papazed/NUSim
that referenced
this pull request
Nov 14, 2026
The rUNSWift branch carried an early copy of NUbots#18 (ball ground truth and ball commands). Conflicts keep rUNSWift's per-robot versions and take main's formatting, comments and BallCommandReader teardown fix. NUbots#37's place_ball() replaces the old centre-mark placement. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
papazed
pushed a commit
to papazed/NUSim
that referenced
this pull request
Nov 14, 2026
Since NUbots#37 the scene ball sits on its geom at the rest point and the keyframes zero-pad it, with SimCore::place_ball putting it back. The old test still expected the geom offset and failed on main. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Math wasn't mathing