Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to pyproject.toml #248

Merged
merged 33 commits into from
Apr 8, 2025
Merged

Move to pyproject.toml #248

merged 33 commits into from
Apr 8, 2025

Conversation

ppinchuk
Copy link
Collaborator

@ppinchuk ppinchuk commented Apr 4, 2025

Also update the pypi publish action to avoid this email from PyPi:

[PyPI] Deprecation notice for recent source distribution upload to 'NREL-reVX

This email is notifying you of an upcoming deprecation that we have determined may affect you as a result of your recent upload to 'NREL-reVX'. 
In the future, PyPI will require all newly uploaded source distribution filenames to comply with PEP 625. Any source distributions already uploaded will remain in place as-is and do not need to be updated. 
Specifically, your recent upload of 'NREL-reVX-0.3.61.tar.gz' is incompatible with PEP 625 because the filename does not contain the normalized project name 'nrel_revx'. 
In most cases, this can be resolved by upgrading the version of your build tooling to a later version that supports PEP 625 and produces compliant filenames. You do not need to remove the file. 

@ppinchuk ppinchuk added chore Maintenance work that does not impact the user dependencies Issues/pull requests related to a dependency deprecation Add a deprecation warning to outdated functionality enhancement Update to logic or general code improvements labels Apr 4, 2025
@ppinchuk ppinchuk self-assigned this Apr 4, 2025
This was linked to issues Apr 4, 2025
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 40.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 74.56%. Comparing base (92d3331) to head (8104dc3).

Files with missing lines Patch % Lines
reVX/utilities/reeds_cols.py 40.00% 2 Missing and 1 partial ⚠️

❌ Your patch status has failed because the patch coverage (40.00%) is below the target coverage (70.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #248      +/-   ##
==========================================
- Coverage   79.32%   74.56%   -4.77%     
==========================================
  Files         118       75      -43     
  Lines       14590    10332    -4258     
  Branches        0     1196    +1196     
==========================================
- Hits        11574     7704    -3870     
+ Misses       3016     2140     -876     
- Partials        0      488     +488     
Flag Coverage Δ
unittests 74.56% <40.00%> (-4.77%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
reVX/utilities/reeds_cols.py 72.60% <40.00%> (-24.66%) ⬇️

... and 102 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ppinchuk ppinchuk merged commit d4457ec into main Apr 8, 2025
7 checks passed
@ppinchuk ppinchuk deleted the pp/pyproject branch April 8, 2025 03:40
github-actions bot pushed a commit that referenced this pull request Apr 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Maintenance work that does not impact the user dependencies Issues/pull requests related to a dependency deprecation Add a deprecation warning to outdated functionality enhancement Update to logic or general code improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to pyproject.toml Deprecate Python 3.8
2 participants