Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create and Modify HX:SensibleAndLatent methods #1835

Merged
merged 13 commits into from
Dec 30, 2024
Merged

Conversation

eringold
Copy link
Collaborator

@eringold eringold commented Oct 21, 2024

Pull request overview

Adds module methods to create and modify HeatExchanger:SensibleAndLatent objects, including necessary edits to TableLookup objects in version 3.8.0 to support zero latent effectivenesse.

Pull Request Author

  • Method changes or additions
  • Added tests for added methods TODO
  • If methods have been deprecated, update rest of code to use the new methods
  • Documented new methods using yard syntax
  • Resolved yard documentation errors for new code (ran bundle exec rake doc)
  • Resolved rubocop syntax errors for new code (ran bundle exec rake rubocop)
  • All new and existing tests passes
  • If the code adds new require statements, ensure these are in core ruby or add to the gemspec

Review Checklist

This will not be exhaustively relevant to every PR.

  • Perform a code review on GitHub
  • All related changes have been implemented: method additions, changes, tests
  • Check rubocop errors
  • Check yard doc errors
  • If fixing a defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If a new feature, test the new feature and try creative ways to break it
  • CI status: all green or justified

@eringold eringold requested a review from mdahlhausen October 21, 2024 19:55
@mdahlhausen mdahlhausen merged commit ce960f5 into master Dec 30, 2024
1 of 2 checks passed
@mdahlhausen mdahlhausen deleted the hx_eff_lookuptables branch December 30, 2024 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants