-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Building Energy Standards Air Conditioner Data Update #1682
base: master
Are you sure you want to change the base?
Conversation
…onversion, fix lookup issues.
…dio-standards into data_update_99d14b7
# Convert from IEER to COP (no fan) | ||
# | ||
# @note IEER is a weighted-average efficiency metrics at different load percentages, operataional and environemental conditions | ||
# @note IEER should be modeled by using performance curves that match a targeted efficiency values | ||
# @note This method estimates what a reasonable full load rated EER would be for a targeted IEER value | ||
# @note The regression used in this method is based on a survey of over 1,000 rated AHRI units with IEER ranging from 11.8 to 25.6 | ||
# @todo Implement methods to handle IEER modeling | ||
# | ||
# @param ieer [Double] Energy Efficiency Ratio (EER) | ||
# @return [Double] Coefficient of Performance (COP) | ||
def ieer_to_cop_no_fan(ieer) | ||
eer = 0.0183 * ieer * ieer - 0.4552 * ieer + 13.21 | ||
|
||
return eer_to_cop_no_fan(eer) | ||
end | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New method to convert an IEER to a COP no fan. Note that this is just to estimate what would a reasonable full load gross COP would be for a specific IEER value. IEER-specific performance curves should then be applied. Copper could be used when it supports IEER rated equipment.
…dio-standards into data_update_99d14b7
@mdahlhausen - I think that this is finally ready for review. As you can see, the build still fails. The failures are due to the regression/performance tests. Could you please have a look at the PR to see if you have comments before I regenerate the regression models and the expected performance tests? All the failures that I see are expected. I see a few different types: 1) Fixes to existing data for 90.1-2004 (wrong SEER value), 2) Naming diffs due to decimal places (if possible, I'd like to keep the new names), 3) This PR assumes default curves for the different coils which might be different from what was used before (the performance curves data is overdue for a cleanup that we're hoping to do on the database side at some point this FY), 4) Even though it doesn't look like it, requirements for 90.1-2019/22 are IEER-only requirements (checked the intent with the 90.1 subcommittees). |
@ckirney can you sync the NECB AC efficiency data / database with this PR? PNNL made some changes to the data schema for applying AC equipment efficiency. |
I'll see what I can do. It might be a little bit though as we have some other high priority tasks. Also, I may not be able to harmonize some data (e.g. curves) since we use NECB data. |
Updates have been made to the Building Energy Standards Data repository, see here. This pull request was automatically generated.