-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Non-transient dwelling unit energy recovery ventilation #1165
Conversation
lib/openstudio-standards/prototypes/ashrae_90_1/ashrae_90_1_2019/ashrae_90_1_2019.Model.rb
Outdated
Show resolved
Hide resolved
…ototype dwelling units whether there is a need for energy recovery or not, if the latter, the ERV only provides ventilation air. Ventilation air at the system is shut-off and the system cycles to meet the load only. The system ERV if added is removed but is used as an indication if energy recovery is needed. Effectiveness of the residential ERV is set based the Enthalpy Recovery Ratio (ERR), which is translated to effectiveness based on regression obtained by analyizing manufacturer data. The translation is design condition dependent (heating or cooling), this corresponds to the err_basis in the code.
@@ -98,6 +98,8 @@ def unique_properties(sheet_name) | |||
['template', 'fluid_type', 'fuel_type', 'condensing', 'condensing_control', 'minimum_capacity', 'maximum_capacity', 'start_date', 'end_date'] | |||
when 'chillers' | |||
['template', 'cooling_type', 'condenser_type', 'compressor_type', 'absorption_type', 'variable_speed_drive', 'minimum_capacity', 'maximum_capacity', 'start_date', 'end_date'] | |||
when 'furnaces' | |||
['template', 'minimum_capacity', 'maximum_capacity', 'start_date', 'end_date'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
merge in the other commit for furnaces to this pull request
@@ -26,6 +26,32 @@ | |||
1.0 | |||
] | |||
}, | |||
{ | |||
"name": "Always On - No DD", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use full name 'Design Day' instead of DD
] | ||
}, | ||
{ | ||
"name": "Always On - No DD", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'Design Day' instead of 'DD'
"10_to_20_percent_oa": null, | ||
"20_to_30_percent_oa": null, | ||
"30_to_40_percent_oa": 5500.0, | ||
"40_to_50_percent_oa": 4500.0, | ||
"50_to_60_percent_oa": 3500.0, | ||
"60_to_70_percent_oa": 2000.0, | ||
"70_to_80_percent_oa": 1000.0, | ||
"greater_than_80_percent_oa": 0.0 | ||
"greater_than_80_percent_oa": 0.0, | ||
"err_basis": null, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use 'enthaply_recovery_ratio' instead of 'err'
# Regressions were determined based available manufacturer data. | ||
# | ||
# @param err [float] Enthalpy Recovery Ratio (ERR) | ||
# @param basis [String] basis for effectiveness calculation, either cooling or heating |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'cooling' or 'heating'
# | ||
# This function is only used for nontransient dwelling units (Mid-rise and High-rise Apartment) | ||
# @param [OpenStudio::Model::HeatExchangerAirToAirSensibleAndLatent] heat exchanger air to air sensible and latent | ||
# @param [String] err |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
parameters not fully explained / specified
# @param [String] err | ||
# @param [String] err basis (Cooling/Heating) | ||
# @param [String] climate zone | ||
def heat_exchanger_air_to_air_sensible_and_latent_apply_prototype_efficiency_err(heat_exchanger_air_to_air_sensible_and_latent, err, basis, climate_zone) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
even though the method name is long, avoid acronyms ('err') in method names
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Minor naming changes - spell out enthalpy recovery ratio instead of 'err' in most cases
- Missing some comments on parameter documentation
- Added schedule should be 'Design Day' instead of 'DD'
- see other comments throughout
…ype from SAC to PSZ-AC to be able to model cycling fan.
@mdahlhausen - Just pushed a commit that addresses the review comments. Please note that there's an additional change: the type of system used by the midrise apartment model. It was original setup to use a split system AC but I ran into #1208 when wanting to change the constant volume fan to cycling. Using a PSZ-AC instead allow the fan to cycle to meet the load which is what we want: system to cycle to meet the load and ERV to provide constant OA with or without energy recovery. |
This PR updates the implementing method about ERV for non-transient dwelling units. The energy simulations require inputs in terms of heat recovery effectiveness. This PR translates the ERR values to effectiveness and insert the new effectiveness into zone ERV. This implementation affects the prototype models for 90.1-2019 mid-rise and high-rise apartments. Additional information regarding the implementation are provided in Section B2.3 in the Energy Savings Analysis: ANSI/ASHRAE/IES Standard 90.1-2019 report.