Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-transient dwelling unit energy recovery ventilation #1165

Merged
merged 15 commits into from
Sep 14, 2021

Conversation

yunyangye
Copy link
Collaborator

@yunyangye yunyangye commented Aug 17, 2021

This PR updates the implementing method about ERV for non-transient dwelling units. The energy simulations require inputs in terms of heat recovery effectiveness. This PR translates the ERR values to effectiveness and insert the new effectiveness into zone ERV. This implementation affects the prototype models for 90.1-2019 mid-rise and high-rise apartments. Additional information regarding the implementation are provided in Section B2.3 in the Energy Savings Analysis: ANSI/ASHRAE/IES Standard 90.1-2019 report.

@yunyangye yunyangye added the 90.1-2016/9 Flag PR targeting code changes related to the 90.1-2016/9 update label Aug 17, 2021
@yunyangye yunyangye requested a review from lymereJ August 17, 2021 22:47
@yunyangye yunyangye changed the title 901 2016 2019 add ce ay erv non-transient dwelling unit energy recovery ventilation Aug 17, 2021
@yunyangye yunyangye changed the title non-transient dwelling unit energy recovery ventilation Non-transient dwelling unit energy recovery ventilation Aug 17, 2021
leijerry888 and others added 5 commits September 1, 2021 13:33
…ototype dwelling units whether there is a need for energy recovery or not, if the latter, the ERV only provides ventilation air. Ventilation air at the system is shut-off and the system cycles to meet the load only. The system ERV if added is removed but is used as an indication if energy recovery is needed. Effectiveness of the residential ERV is set based the Enthalpy Recovery Ratio (ERR), which is translated to effectiveness based on regression obtained by analyizing manufacturer data. The translation is design condition dependent (heating or cooling), this corresponds to the err_basis in the code.
@@ -98,6 +98,8 @@ def unique_properties(sheet_name)
['template', 'fluid_type', 'fuel_type', 'condensing', 'condensing_control', 'minimum_capacity', 'maximum_capacity', 'start_date', 'end_date']
when 'chillers'
['template', 'cooling_type', 'condenser_type', 'compressor_type', 'absorption_type', 'variable_speed_drive', 'minimum_capacity', 'maximum_capacity', 'start_date', 'end_date']
when 'furnaces'
['template', 'minimum_capacity', 'maximum_capacity', 'start_date', 'end_date']
Copy link
Collaborator

@mdahlhausen mdahlhausen Sep 13, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merge in the other commit for furnaces to this pull request

@@ -26,6 +26,32 @@
1.0
]
},
{
"name": "Always On - No DD",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use full name 'Design Day' instead of DD

]
},
{
"name": "Always On - No DD",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'Design Day' instead of 'DD'

"10_to_20_percent_oa": null,
"20_to_30_percent_oa": null,
"30_to_40_percent_oa": 5500.0,
"40_to_50_percent_oa": 4500.0,
"50_to_60_percent_oa": 3500.0,
"60_to_70_percent_oa": 2000.0,
"70_to_80_percent_oa": 1000.0,
"greater_than_80_percent_oa": 0.0
"greater_than_80_percent_oa": 0.0,
"err_basis": null,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use 'enthaply_recovery_ratio' instead of 'err'

# Regressions were determined based available manufacturer data.
#
# @param err [float] Enthalpy Recovery Ratio (ERR)
# @param basis [String] basis for effectiveness calculation, either cooling or heating
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'cooling' or 'heating'

#
# This function is only used for nontransient dwelling units (Mid-rise and High-rise Apartment)
# @param [OpenStudio::Model::HeatExchangerAirToAirSensibleAndLatent] heat exchanger air to air sensible and latent
# @param [String] err
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

parameters not fully explained / specified

# @param [String] err
# @param [String] err basis (Cooling/Heating)
# @param [String] climate zone
def heat_exchanger_air_to_air_sensible_and_latent_apply_prototype_efficiency_err(heat_exchanger_air_to_air_sensible_and_latent, err, basis, climate_zone)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

even though the method name is long, avoid acronyms ('err') in method names

Copy link
Collaborator

@mdahlhausen mdahlhausen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Minor naming changes - spell out enthalpy recovery ratio instead of 'err' in most cases
  • Missing some comments on parameter documentation
  • Added schedule should be 'Design Day' instead of 'DD'
  • see other comments throughout

@NREL NREL deleted a comment from yunyangye Sep 14, 2021
@NREL NREL deleted a comment from yunyangye Sep 14, 2021
@NREL NREL deleted a comment from yunyangye Sep 14, 2021
@NREL NREL deleted a comment from yunyangye Sep 14, 2021
@NREL NREL deleted a comment from yunyangye Sep 14, 2021
@NREL NREL deleted a comment from yunyangye Sep 14, 2021
@NREL NREL deleted a comment from yunyangye Sep 14, 2021
@NREL NREL deleted a comment from yunyangye Sep 14, 2021
@NREL NREL deleted a comment from yunyangye Sep 14, 2021
…ype from SAC to PSZ-AC to be able to model cycling fan.
@lymereJ
Copy link
Collaborator

lymereJ commented Sep 14, 2021

@mdahlhausen - Just pushed a commit that addresses the review comments. Please note that there's an additional change: the type of system used by the midrise apartment model. It was original setup to use a split system AC but I ran into #1208 when wanting to change the constant volume fan to cycling. Using a PSZ-AC instead allow the fan to cycle to meet the load which is what we want: system to cycle to meet the load and ERV to provide constant OA with or without energy recovery.

@lymereJ lymereJ requested a review from mdahlhausen September 14, 2021 05:44
@lymereJ lymereJ merged commit dabd507 into 901_2016_2019 Sep 14, 2021
@mdahlhausen mdahlhausen deleted the 901_2016_2019_add_ce_ay_erv branch April 15, 2022 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
90.1-2016/9 Flag PR targeting code changes related to the 90.1-2016/9 update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants