Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Geocode zip to lat/lon for urdb utility rates #2053

Merged
merged 1 commit into from
Apr 4, 2025

Conversation

cpaulgilman
Copy link
Collaborator

@cpaulgilman cpaulgilman commented Apr 4, 2025

Pull Request Template

Description

See #2034 for description.

Solution is to geocode zip code to lat/lon and then submit lat/lon to URDB API to get list of utility companies. (Geocode API does identify zip codes correctly.)

Fixes #2034

Corresponding branches and PRs:

Goes with https://github.com/NREL/SAM-private/pull/123

Checklist

  • requires help revision and I added that label
  • adds, removes, modifies, or deletes variables in existing compute modules
  • adds a new compute module
  • changes defaults
  • I've tagged this PR to a milestone

@cpaulgilman cpaulgilman added this to the SAM Spring 2025 Release milestone Apr 4, 2025
@cpaulgilman cpaulgilman requested review from brtietz and sjanzou April 4, 2025 17:27
@cpaulgilman cpaulgilman self-assigned this Apr 4, 2025
@cpaulgilman cpaulgilman added utility rate UI User interface issue that applies across performance and financial models labels Apr 4, 2025
Copy link
Collaborator

@brtietz brtietz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well and gives appropriate error messages for invalid zip codes.

@cpaulgilman cpaulgilman merged commit fdcc73b into develop Apr 4, 2025
8 checks passed
@cpaulgilman cpaulgilman deleted the sam-2034-urdb-rates-by-zip branch April 4, 2025 20:45
@cpaulgilman cpaulgilman added the added to release notes PR and/or issue has been added to release notes for a public release label Apr 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
added to release notes PR and/or issue has been added to release notes for a public release UI User interface issue that applies across performance and financial models utility rate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

URDB rate by zip code API service update
2 participants