Remove AVM for AirLoopHVACOutdoorAirSystem #5252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kbenne
added
the
Pull Request - Ready for CI
joseph-robertson
approved these changes
Sep 9, 2024
jmarrec
approved these changes
Oct 29, 2024
Comment on lines
109
to
-126
|
|
||
| // Field: Availability Manager List Name ////////////////////////////////// | ||
| IdfObject availabilityManagerListIdf(IddObjectType::AvailabilityManagerAssignmentList); | ||
| availabilityManagerListIdf.setName(name + " Availability Manager List"); | ||
| m_idfObjects.push_back(availabilityManagerListIdf); | ||
|
|
||
| IdfObject availabilityManagerScheduledIdf = IdfObject(openstudio::IddObjectType::AvailabilityManager_Scheduled); | ||
| availabilityManagerScheduledIdf.setName(name + " Availability Manager"); | ||
| m_idfObjects.push_back(availabilityManagerScheduledIdf); | ||
|
|
||
| Schedule alwaysOn = modelObject.model().alwaysOnDiscreteSchedule(); | ||
| IdfObject alwaysOnIdf = translateAndMapModelObject(alwaysOn).get(); | ||
|
|
||
| availabilityManagerListIdf.setString(1 + openstudio::AvailabilityManagerAssignmentListExtensibleFields::AvailabilityManagerObjectType, | ||
| availabilityManagerScheduledIdf.iddObject().name()); | ||
| availabilityManagerListIdf.setString(1 + openstudio::AvailabilityManagerAssignmentListExtensibleFields::AvailabilityManagerName, | ||
| availabilityManagerScheduledIdf.name().get()); | ||
| availabilityManagerScheduledIdf.setString(openstudio::AvailabilityManager_ScheduledFields::ScheduleName, alwaysOnIdf.name().get()); |
There was a problem hiding this comment.
Since 9.6.0, this AVM + AVM List was written to the IDF, but not actually used since the field itself was removed.
The removal of the use of this AVM List is in this commit of yours @joseph-robertson : a7962bf
jmarrec
force-pushed
the
5251-remove-avm-from-oa-system
branch
from
75b06aa to
d707162
Compare
|
Just triggering CI once again after a rebase to make sure everything is still right, and this can drop in. |
|
CI Results for d707162:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #5251