Update to EnergyPlus v24.2.0a #5242

joseph-robertson · 2024-08-26T20:00:54Z

Pull request overview

Fixes Update to EnergyPlus 24.2.0 #5240

Pull Request Author

Model API Changes / Additions
Any new or modified fields have been implemented in the EnergyPlus ForwardTranslator (and ReverseTranslator as appropriate)
Model API methods are tested (in src/model/test)
EnergyPlus ForwardTranslator Tests (in src/energyplus/Test)
If a new object or method, added a test in NREL/OpenStudio-resources: Add Link
If needed, added VersionTranslation rules for the objects (src/osversion/VersionTranslator.cpp)
Verified that C# bindings built fine on Windows, partial classes used as needed, etc.
All new and existing tests passes
If methods have been deprecated, update rest of code to use the new methods

Labels:

If change to an IDD file, add the label IDDChange
If breaking existing API, add the label APIChange
If deemed ready, add label Pull Request - Ready for CI so that CI builds your PR

Review Checklist

This will not be exhaustively relevant to every PR.

Perform a Code Review on GitHub
Code Style, strip trailing whitespace, etc.
All related changes have been implemented: model changes, model tests, FT changes, FT tests, VersionTranslation, OS App
Labeling is ok
If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
If feature, test running new feature, try creative ways to break it
CI status: all green or justified

V24.2.0-IOFreeze: AirTerminalSingleDuctXXXPIUReheat's new fields, follow-up

Make pip install run only once instead of everytime CMake reconfigures

Built the arm64 linux (22.04 and 24.04), the windows i386, and the Centos one. https://github.com/NREL/EnergyPlus/releases/tag/v24.2.0a

Update to E+ v24.2.0a

jmarrec · 2024-10-07T21:38:25Z

Ok I think this is pretty much ready to drop, except CI is very broken and I don't have the rights to make changes. So it's hard to tell if the tests are green...

I can vouch for Ubuntu (24.04) and macOS (arm64) building just fine.

I have test failures on macOS arm64, but I often have numerical inconsistencies on that machine

Tests I think should be fine on other machines:

	171 - SqlFileFixture.AnnualTotalCosts (Failed)
	464 - GeometryFixture.Plane_RayIntersection (Failed)
	3535 - ISOModelFixture.SimModel (Failed)

Other tests that are suspicious.

	2949 - EnergyPlusFixture.ForwardTranslator_AirTerminalSingleDuctParallelPIUReheat (Failed)
2949: [ RUN      ] EnergyPlusFixture.ForwardTranslator_AirTerminalSingleDuctParallelPIUReheat
2949: /Users/julien/Software/Others/OpenStudio2/src/energyplus/Test/AirTerminalSingleDuctParallelPIUReheat_GTest.cpp:75: Failure
2949: Expected equality of these values:
2949:   atu.nameString() + " Fan Outlet"
2949:     Which is: "Air Terminal Single Duct Parallel PIU Reheat 1 Fan Outlet"
2949:   idf_atu.getString(AirTerminal_SingleDuct_ParallelPIU_ReheatFields::ReheatCoilAirInletNodeName, false).get()
2949:     Which is: "Air Terminal Single Duct Parallel PIU Reheat 1 Mixer Outlet"

	3782 - OpenStudioCLI.Run_RubyPythonPlugin (Failed)

This is an E+ error, and the eplusout.err has

3782: Test command: /Users/julien/Software/Others/OS-build-release2/Products/openstudio "run" "--show-stdout" "-w" "python_plugin_jinja_erb.osw"
3782: Working Directory: /Users/julien/Software/Others/OS-build-release2/resources/workflow/python_plugin/
3782: Test timeout computed to be: 1500
3782: [openstudio.energyplus.ForwardTranslator] <Warn> Object of type 'OS:ThermalZone' and named 'Thermal Zone 1' has DaylightingControl Objects assigned. The interior walls between Spaces will be merged. Make sure these are correctly Matched!
3782: ExpandObjects Started.
3782: No expanded file generated.
3782: ExpandObjects Finished. Time:     0.009
3782: EnergyPlus Starting
3782: EnergyPlus, Version 24.2.0-94a887817b, YMD=2024.10.07 23:36
3782: **FATAL:Python import error causes program termination
3782: EnergyPlus Run Time=00hr 00min  0.06sec
3782: Program terminated: EnergyPlus Terminated--Error(s) Detected.
3782: [openstudio.workflow.OSWorkflow] <Warn> EnergyPlus returned a non-zero exit code (1). Check the stdout-energyplus log
3782: [openstudio.workflow.OSWorkflow] <Fatal> EnergyPlus Terminated with a Fatal Error. Check eplusout.err log.
3782: [openstudio.workflow.OSWorkflow] <Error> Found error in state 'EnergyPlus' with message: '/Users/julien/Software/Others/OpenStudio2/src/workflow/RunEnergyPlus.cpp@311 : EnergyPlus Terminated with a Fatal Error. Check eplusout.err log.'
3782: Failed to run workflow. Last Error:
3782:   Found error in state 'EnergyPlus' with message: '/Users/julien/Software/Others/OpenStudio2/src/workflow/RunEnergyPlus.cpp@311 : EnergyPlus Terminated with a Fatal Error. Check eplusout.err log.'
1/1 Test #3782: OpenStudioCLI.Run_RubyPythonPlugin ...***Failed  Required regular expression not found. Regex=[HI FROM ERB PYTHON PLUGIN[
	 ]*HI FROM JINJA PYTHON PLUGIN
]  1.28 sec

@joseph-robertson can you report on what you find on windows? Does it build? How are tests?

jmarrec · 2024-10-07T22:48:53Z

Hum the Run_RubyPythonPlugin thing is a codesigning issue, so mac only. I think I can fix it, but it's going to require rebuilding an E+ package...

jmarrec · 2024-10-08T00:14:59Z

.github/workflows/cppcheck.yml

+    runs-on: ubuntu-20.04
+    # That container is too old to work with the actions that are on node20 now...
+    #container:
+    #  image: nrel/cppcheck:2.3
    steps:
-    - uses: actions/checkout@v3
+    - uses: actions/checkout@v4
+
+    - name: Install cppcheck
+      shell: bash
+      run: |
+        # I made a PPA on launchpad where I built cppcheck 2.3 for focal
+        sudo add-apt-repository ppa:jmarrec/ppa
+        sudo apt update
+        sudo apt install -y cppcheck
+        cppcheck --version
+


Unbrick the cppcheck workflow... since that one is on Github actions, I can do that. And apparently I had already made a launchpad PPA that built cppcheck 2.3 for focal a year ago (can't remember how I did that...)

ci-commercialbuildings · 2024-10-24T04:52:47Z

CI Results for 37d6cca:

Ubuntu 24.04:
Ubuntu 22.04:
Darwin:
- OpenStudio-3.9.0-alpha+37d6cca47d-Darwin-x86_64.dmg
- OpenStudio-3.9.0-alpha+37d6cca47d-Darwin-x86_64.tar.gz
Windows:
- OpenStudio-3.9.0-alpha+37d6cca47d-Windows.exe
- OpenStudio-3.9.0-alpha+37d6cca47d-Windows.tar.gz
Code Coverage:

joseph-robertson added 2 commits August 26, 2024 12:59

Update cmakelists.

9505514

Update proposed idd.

48870bc

joseph-robertson added Pull Request - Ready for CI This pull request if finalized and is ready for continuous integration verification prior to merge. IDDChange labels Aug 26, 2024

joseph-robertson linked an issue Aug 27, 2024 that may be closed by this pull request

Update to EnergyPlus 24.2.0 #5240

Closed

14 tasks

joseph-robertson added 3 commits August 27, 2024 09:11

Stub ft, vt, and idd version change.

5b6a2d8

Formatting.

120b087

Updates for illuminancemap and internalmass.

9de4c78

joseph-robertson self-assigned this Aug 27, 2024

joseph-robertson added 21 commits August 27, 2024 15:07

Update idd.

e72ad98

Update model, ft, and rt files.

86372d2

Update vt and add test.

c6bd269

Formatting.

91318b2

Update idd.

1fe9b3c

Start updating model files.

5206884

Updates for vt.

87063c3

Formatting.

5432994

Few fixes in vt and test.

fd72e0e

Bump project version in cmakelists.

843c4b5

Merge branch 'v24.2.0-IOFreeze' into v24.2.0-IOFreeze-ocfiles

9760e4b

Remove misplaced line in vt.

5b52841

Update idd.

b90e787

Update aterm model files.

44184d2

Update aterm ft files.

f8cc5d5

Add tertiary getters and setters.

5271416

Fixes in idd and vt.

0bde9d0

Update ft.

cee2981

Add model tests for heat recovery loop.

be8b1d6

Update setter logic for fan control types.

af4ff2c

Add model tests for new fields and methods.

7bbf479

joseph-robertson and others added 9 commits October 3, 2024 15:10

Include Node in ft test files.

968ad4d

Merge pull request #5268 from NREL/v24.2.0-IOFreeze-aterm2

849d53a

V24.2.0-IOFreeze: AirTerminalSingleDuctXXXPIUReheat's new fields, follow-up

Merge branch 'v24.2.0-IOFreeze' into v24.2.1-RC1

4b2c04d

Merge pull request #5266 from NREL/pip_install_once

5e2016b

Make pip install run only once instead of everytime CMake reconfigures

Update site ft test comment. [ci skip]

66782e8

Update eplus release name.

7d61e87

Merge branch 'v24.2.0-IOFreeze' into v24.2.1-RC1

e34e5a2

Update all hashes

61df624

Built the arm64 linux (22.04 and 24.04), the windows i386, and the Centos one. https://github.com/NREL/EnergyPlus/releases/tag/v24.2.0a

Merge pull request #5267 from NREL/v24.2.1-RC1

25fec1d

Update to E+ v24.2.0a

jmarrec changed the title ~~Update to EnergyPlus v24.2.0~~ Update to EnergyPlus v24.2.0a Oct 7, 2024

jmarrec mentioned this pull request Oct 7, 2024

OS does not compile with recent GCC: std::move calls throw warnings #5262

Closed

joseph-robertson assigned jmarrec Oct 7, 2024

Bump actions

3ccb0f9

jmarrec added 3 commits October 8, 2024 01:44

Fix the ParallPIU test

be576ec

Try to unbrick cppcheck that runs on a too old container for node20

ce9d156

ubunut 22.04 has cppcheck 2.7, use focal so I can use my PPA.

a81ac39

jmarrec reviewed Oct 8, 2024

View reviewed changes

jmarrec mentioned this pull request Oct 9, 2024

Addresses #5227, updates to Controller:OutdoorAir #5237

Merged

27 tasks

joseph-robertson and others added 6 commits October 9, 2024 11:24

Merge branch 'develop' into v24.2.0-IOFreeze

d140f59

Update the entry point of jenkinsfile.

12ff7f7

Update Jenkins file to call the ci.

1d35483

Remove the Jenkinsfile

6dfe06c

Merge branch 'develop' into v24.2.0-IOFreeze

c8e9229

Merge branch 'develop' into v24.2.0-IOFreeze

37d6cca

joseph-robertson merged commit 023c513 into develop Oct 25, 2024
3 of 6 checks passed

joseph-robertson deleted the v24.2.0-IOFreeze branch October 25, 2024 21:56

jmarrec mentioned this pull request Oct 29, 2024

Python Import Error on macOS after upgrading to E+ 24.2.0a #5281

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update to EnergyPlus v24.2.0a #5242

Update to EnergyPlus v24.2.0a #5242

joseph-robertson commented Aug 26, 2024 •

edited by jmarrec

Loading

jmarrec commented Oct 7, 2024 •

edited

Loading

jmarrec commented Oct 7, 2024

jmarrec Oct 8, 2024 •

edited

Loading

ci-commercialbuildings commented Oct 24, 2024 •

edited

Loading

Update to EnergyPlus v24.2.0a #5242

Update to EnergyPlus v24.2.0a #5242

Conversation

joseph-robertson commented Aug 26, 2024 • edited by jmarrec Loading

Pull request overview

Pull Request Author

Review Checklist

jmarrec commented Oct 7, 2024 • edited Loading

jmarrec commented Oct 7, 2024

jmarrec Oct 8, 2024 • edited Loading

Choose a reason for hiding this comment

ci-commercialbuildings commented Oct 24, 2024 • edited Loading

joseph-robertson commented Aug 26, 2024 •

edited by jmarrec

Loading

jmarrec commented Oct 7, 2024 •

edited

Loading

jmarrec Oct 8, 2024 •

edited

Loading

ci-commercialbuildings commented Oct 24, 2024 •

edited

Loading