Fix heredoc in energyplus.rb #152
Conversation
|
Cursory look, the repo has a ton of issues with respect to run on Ruby 3. This is why you need CI to, you know, work. Seems like the Jenkins script uses Ubuntu 18.04 (which we don't support anymore mind you), and a docker openstudio at 3.2.1. Hasn't been touched in more than 3 years. |
…emoved in Ruby 3.2
| gem 'openstudio_measure_tester', '~> 0.4.0', :github => 'NREL/OpenStudio-measure-tester-gem', :ref => '1baa9e70254a0cdb6740ccf14052baada8cf9e1c' | ||
|
|
| @@ -382,7 +382,7 @@ def apply_measure(registry, step, options = {}, energyplus_output_requests = fal | |||
| else | |||
| skip_measure = true | |||
| end | |||
| elsif argument_value.class == Fixnum | |||
| elsif argument_value.class == Integer | |||
There was a problem hiding this comment.
Fixnum and Bignum are deprecated since Ruby 2.4, unified by Integer. And now it's gone in 3.x
| @@ -23,7 +23,7 @@ Gem::Specification.new do |s| | |||
|
|
|||
| s.add_development_dependency 'builder', '~> 3.2.4' | |||
| s.add_development_dependency 'bundler', '>= 2.5.5' | |||
| s.add_development_dependency 'ci_reporter', '~> 2.0.0' | |||
| s.add_development_dependency 'ci_reporter', '~> 2.1.0' | |||
There was a problem hiding this comment.
This uses File.exists? (not File.exist) and was from 2014
| msgpack_flag = false | ||
| csv_flag = false | ||
| if output_format == "MessagePack" || output_format == "Both" | ||
| msgpack_flag = TRUE | ||
| msgpack_flag = true | ||
| end | ||
| if output_format == "CSV" || output_format == "Both" | ||
| csv_flag = TRUE | ||
| csv_flag = true |
There was a problem hiding this comment.
FALSE, TRUE, NIL deprecated since Ruby 2.4, gone in 3.x
|
@kbenne Can confirm that I can run the workflow from here using system ruby connected to my build of 3.8.0-beta. There are a few tests failing (not my concern) but most of them are ok |
ref NREL/OpenStudio#5157