-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ccaradon/hprtu debug #245
Merged
JanghyunJK
merged 24 commits into
jk/hprtu_final_final_new_sampling
from
ccaradon/hprtu_debug
Oct 29, 2024
Merged
Ccaradon/hprtu debug #245
JanghyunJK
merged 24 commits into
jk/hprtu_final_final_new_sampling
from
ccaradon/hprtu_debug
Oct 29, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
latex fixes to figures, references adding soil properties section updating kitchen equipment power values
…horship' into documentation-fixes
Rhorsey/sampling v2 plotting patch
fixes to documentation
…rflow interference
29 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request overview
This PR primarily addresses errors in the HP RTU measure caused by a bug in the OpenStudio FT. The errors occur when there is a mismatch between heating and cooling speeds, which is allowed in E+, but is incorrectly articulated in the FT causing failure.
The temporary fix is to create 'dummy' speed levels to ensure that the number of speeds for heating and cooling are always equal. The dummy speeds are set to match the parameters of the lowest 'real' speed. For instance, if heating has 2 speeds and cooling has 4, the heating system will be assigned 4 speeds, where the lowest 2 are duplicates of the lowest actual speed.
This workflow should be modified once the OpenStudio FT issue is resolved: NREL/OpenStudio#5277
Pull Request Author: Chris CaraDonna
This pull request makes changes to (select all the apply):
Author pull request checklist:
comstock_column_definitions.csv
options_lookup.tsv
files updated.yml
filesREADME.md
filestest/measure_tests.txt
or/andtest/resource_measure_tests.txt
Review Checklist
This will not be exhaustively relevant to every PR.
ComStock Licensing Language - Add to Beginning of Each Code File