Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use JSON schemas for Sienna model intermediary layer #5

Open
wants to merge 20 commits into
base: main
Choose a base branch
from
Open

Use JSON schemas for Sienna model intermediary layer #5

wants to merge 20 commits into from

Conversation

josephmckinsey
Copy link

@josephmckinsey josephmckinsey commented Oct 22, 2024 •
edited
Loading

Python Database Creation

  • Pydantic schemas for tables
  • sqlalchemy database generation

JSON Schema Models

  • ThermalStandard
  • ACBus
  • Line
  • Area
  • Transformer
  • ???

Python Classes

  • pytest for json schema models
  • Working automated tests

Julia Structs

  • Testing OpenAPI generation
  • Julia tests for generated structs
  • Example conversion for struct

Joseph McKinsey added 20 commits October 8, 2024 10:38
Initial testing
31aa85b
Add pydantic + annotations method
1f54feb
Add better serialization of columns in JSON Schema
2aa2130
Move files to separate hand-written schemas
873ce68
Move to hand-defined schemas
98f0656
Add python tests, automatic testing, pyproject.toml, and .github/work…
699e73f 
…flows/schema-gen.yml
Fix pyproject.toml and .github
10b7a05
Remove requirements.txt and add .gitignore
c92657f
Add openapi schema generation
4699fbf
Adjust the dependencies installed for datamodel code gen
2ca2041
Add updates to schemas, along with generated code + src/sienna_struct…
f1a5019 
…_conversion.jl
Add precommit
11aa859
Finish creating testing for the julia models
af75f09
Add julia gitignore
0ccda21
Fix diff using precommit formatting
a20ef3b
Try fixing actions yet again
498c9a5
Fix permission problems in schema-gen.yml
6d3ae6f
Fix @test command
3745368
Update models with regenerated for ordering
2fa588c
Update docs with newest models
d384c15
@josephmckinsey josephmckinsey changed the title WIP: Use JSON schemas for Sienna model intermediary layer Use JSON schemas for Sienna model intermediary layer Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pesap pesap pesap left review comments

@daniel-thom daniel-thom Awaiting requested review from daniel-thom

@jd-lara jd-lara Awaiting requested review from jd-lara

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@josephmckinsey @pesap