Feat/#19 week_compose7 필수과제 구현 #20
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hyeeum
approved these changes
Jun 9, 2024
There was a problem hiding this comment.
오 이 부분 발견 못했을 법도 한데 어떻게 발견하셨나요 역시 세심하시네요
| @@ -103,7 +103,7 @@ private fun LoginScreen( | |||
| TextFieldWithTitleComposable( | |||
| title = R.string.title_pw, | |||
| label = R.string.login_label_pw, | |||
| textFieldText = uiState.pw, | |||
| textFieldText = uiState.password, | |||
There was a problem hiding this comment.
축약어도 수정하셨군요,저도 이렇게 pw이나 nick등으로 축약어 사용했는데 수정했답니다..
youjin09222
approved these changes
Jun 9, 2024
| @@ -65,7 +66,7 @@ fun HomeScreen( | |||
| Scaffold( | |||
| bottomBar = { SoptBottomNavigation(navController = navController) } | |||
| ) { paddingValue -> | |||
| when (val uiState = viewModel.uiState.collectAsState().value) { | |||
| when (val uiState = viewModel.uiState.collectAsStateWithLifecycle(LocalLifecycleOwner.current).value) { | |||
There was a problem hiding this comment.
오 collectAsStateWithLifecycle 함수를 사용하면 Compose UI에서 상태를 관리하는 과정이 단순화되고, 생명주기에 따라 안전하게 처리된다고 하네요! 하나 배워갑니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌𝘐𝘴𝘴𝘶𝘦𝘴
📎𝘞𝘰𝘳𝘬 𝘋𝘦𝘴𝘤𝘳𝘪𝘱𝘵𝘪𝘰𝘯
📷𝘚𝘤𝘳𝘦𝘦𝘯𝘴𝘩𝘰𝘵
이전과 동일하므로 따로 올리진 않겠습니다!
💬𝘛𝘰 𝘙𝘦𝘷𝘪𝘦𝘸𝘦𝘳𝘴
4주차 코드 리뷰에 대해 코드 수정을 해봤습니다!!
저장소 관련 코드는 이전 주차에 만들어두었고, 패키지 구조만 다시 수정했어요~