[2주차/필수/XML] Android UI 구현 심화 #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2hyunjinn
reviewed
Apr 19, 2024
| testImplementation 'junit:junit:4.13.2' | ||
| androidTestImplementation 'androidx.test.ext:junit:1.1.5' | ||
| androidTestImplementation 'androidx.test.espresso:espresso-core:3.5.1' | ||
|
|
||
| // ViewModel 의존성 설정 | ||
| implementation "androidx.lifecycle:lifecycle-viewmodel-ktx:2.6.2" |
2hyunjinn
reviewed
Apr 19, 2024
| binding = ActivityMainBinding.inflate(layoutInflater) | ||
| setContentView(binding.root) | ||
|
|
||
| val userId = intent.getStringExtra("ID") |
There was a problem hiding this comment.
슬슬 data class와 직렬화에 대해 공부해볼까요?
junseo511
approved these changes
Apr 21, 2024
| binding = ActivityMainBinding.inflate(layoutInflater) | ||
| setContentView(binding.root) | ||
|
|
||
| val userId = intent.getStringExtra("ID") |
There was a problem hiding this comment.
슬슬 data class와 직렬화에 대해 공부해볼까요?
Comment on lines
+24
to
+29
| val currentFragment = supportFragmentManager.findFragmentById(binding.fcvMain.id) | ||
| if (currentFragment == null) { | ||
| supportFragmentManager.beginTransaction() | ||
| .add(binding.fcvMain.id, HomeFragment()) | ||
| .commit() | ||
| } |
Comment on lines
+55
to
+58
| putString("ID", userId) | ||
| putString("PW", userPw) | ||
| putString("Name", userName) | ||
| putString("Place", userPlace) |
Comment on lines
+70
to
+74
| private fun replaceFragment(fragment: Fragment) { | ||
| supportFragmentManager.beginTransaction() | ||
| .replace(binding.fcvMain.id, fragment) | ||
| .commit() | ||
| } |
Comment on lines
+53
to
+56
| intent.putExtra("ID", userId) | ||
| intent.putExtra("PW", userPw) | ||
| intent.putExtra("Name", userName) | ||
| intent.putExtra("Place", userPlace) |
There was a problem hiding this comment.
묶어주시면 편안할듯 아린님 코드에 파트장님이 리뷰 남기셨네용
Comment on lines
+13
to
+16
| val ID_MIN_LENGTH = 6 | ||
| val ID_MAX_LENGTH = 10 | ||
| val PW_MIN_LENGTH = 8 | ||
| val PW_MAX_LENGTH = 12 |
Comment on lines
+40
to
+43
| override fun onDestroyView() { | ||
| super.onDestroyView() | ||
| _binding = null | ||
| } |
There was a problem hiding this comment.
Suggested change
| override fun onDestroyView() { | |
| super.onDestroyView() | |
| _binding = null | |
| } | |
| override fun onDestroyView() { | |
| _binding = null | |
| super.onDestroyView() | |
| } |
이쪽이 안정성이 더 좋습니다!! 이유는 뭘까요?!
There was a problem hiding this comment.
아! 데이터 클래스가 이미 있네요 직렬화로 넘기는 방법을 배워볼까요?!
Comment on lines
+38
to
+41
| binding.tvMyPageShowId.text = userId | ||
| binding.tvMyPageShowPw.text = userPw | ||
| binding.tvMyPageShowName.text = userName | ||
| binding.tvMyPageShowPlace.text = userPlace |
arinming
reviewed
Apr 21, 2024
| <item | ||
| android:id="@+id/menu_home" | ||
| android:icon="@drawable/ic_home_white_24" | ||
| android:title="홈" /> |
Comment on lines
+64
to
+67
| companion object { | ||
| const val TYPE_MY_PROFILE = 0 | ||
| const val TYPE_FRIEND_PROFILE = 1 | ||
| } |
| } | ||
|
|
||
| override fun getItemCount(): Int { | ||
| return friendList.size + 1 |
| } | ||
|
|
||
| override fun getItemViewType(position: Int): Int { | ||
| return if (position == 0) TYPE_MY_PROFILE else TYPE_FRIEND_PROFILE |
Comment on lines
+37
to
+42
| is MyProfileViewHolder -> { | ||
| holder.onBind(myProfile) | ||
| } | ||
|
|
||
| is FriendViewHolder -> { | ||
| holder.onBind(friendList[position - 1]) |
yeonjeen
reviewed
Apr 21, 2024
|
|
||
| binding.btnSignInSignUp.setOnClickListener { | ||
| val intent = Intent(this, SignUpActivity::class.java) | ||
| startActivity(intent) |
|
|
||
| private fun showToast(message: String) { | ||
| Toast.makeText(this, message, Toast.LENGTH_SHORT).show() | ||
| } |
| navigateToSignInActivity() | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
안드를 이제 시작했는데 when 이리 잘 쓰다니... 이 부분은 말 그대로 검증하는 부분이니까 뷰모델로 빼도 괜찮을 것 같아용!! 비즈니스 로직만 한 번 분리해보셔요~
| name = "Charles Barkley", | ||
| place = "USA, Philadelphia", | ||
| selfDescription = "CHUCK CHUCK" | ||
| ) |
| app:layoutManager="androidx.recyclerview.widget.LinearLayoutManager" | ||
| app:layout_constraintBottom_toBottomOf="parent" | ||
| app:layout_constraintEnd_toEndOf="parent" | ||
| app:layout_constraintStart_toStartOf="parent" |
There was a problem hiding this comment.
width가 match이니까 start랑 end 값은 주지 않아도 괜찮아요! 우리의 소중한 리소스를 절약해봐요 ㅎㅎ
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue 🛠
Work Description ✏️
Screenshot 📸
2._XML_.mp4
Uncompleted Tasks 😅
To Reviewers 📢
피를 토하며 열심히 해보았습니다.. 굉장히 험난했지만 1주차 과제때에 비해 코드가 굉장히 나아지지 않았나 스스로 생각하며 위안을 얻어 봅니다..!