week4: 4차 필수과제 진행(Compose) #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
junseo511
requested changes
May 5, 2024
Comment on lines
+10
to
+21
| object ApiFactory { | ||
| private const val BASE_URL: String = BuildConfig.AUTH_BASE_URL | ||
|
|
||
| val retrofit: Retrofit by lazy { | ||
| Retrofit.Builder() | ||
| .baseUrl(BASE_URL) | ||
| .addConverterFactory(Json.asConverterFactory("application/json".toMediaType())) | ||
| .build() | ||
| } | ||
|
|
||
| inline fun <reified T> create(): T = retrofit.create(T::class.java) | ||
| } |
There was a problem hiding this comment.
Suggested change
| object ApiFactory { | |
| private const val BASE_URL: String = BuildConfig.AUTH_BASE_URL | |
| val retrofit: Retrofit by lazy { | |
| Retrofit.Builder() | |
| .baseUrl(BASE_URL) | |
| .addConverterFactory(Json.asConverterFactory("application/json".toMediaType())) | |
| .build() | |
| } | |
| inline fun <reified T> create(): T = retrofit.create(T::class.java) | |
| } | |
| object ApiFactory { | |
| private const val BASE_URL: String = BuildConfig.AUTH_BASE_URL | |
| val retrofit: Retrofit by lazy { | |
| Retrofit.Builder() | |
| .baseUrl(BASE_URL) | |
| .addConverterFactory(Json.asConverterFactory("application/json".toMediaType())) | |
| .build() | |
| } | |
| inline fun <reified T> create(): T = retrofit.create() | |
| } |
class Type을 매개변수로 넘겨주지 않아도 됩니다!
murjune
suggested changes
May 6, 2024
Comment on lines
+10
to
+21
| object ApiFactory { | ||
| private const val BASE_URL: String = BuildConfig.AUTH_BASE_URL | ||
|
|
||
| val retrofit: Retrofit by lazy { | ||
| Retrofit.Builder() | ||
| .baseUrl(BASE_URL) | ||
| .addConverterFactory(Json.asConverterFactory("application/json".toMediaType())) | ||
| .build() | ||
| } | ||
|
|
||
| inline fun <reified T> create(): T = retrofit.create(T::class.java) | ||
| } |
There was a problem hiding this comment.
Suggested change
| object ApiFactory { | |
| private const val BASE_URL: String = BuildConfig.AUTH_BASE_URL | |
| val retrofit: Retrofit by lazy { | |
| Retrofit.Builder() | |
| .baseUrl(BASE_URL) | |
| .addConverterFactory(Json.asConverterFactory("application/json".toMediaType())) | |
| .build() | |
| } | |
| inline fun <reified T> create(): T = retrofit.create(T::class.java) | |
| } | |
| object ApiFactory { | |
| private const val BASE_URL: String = BuildConfig.AUTH_BASE_URL | |
| val retrofit: Retrofit by lazy { | |
| Retrofit.Builder() | |
| .baseUrl(BASE_URL) | |
| .addConverterFactory(Json.asConverterFactory("application/json".toMediaType())) | |
| .build() | |
| } | |
| inline fun <reified T> create(): T = retrofit.create() | |
| } |
class Type을 매개변수로 넘겨주지 않아도 됩니다!
Comment on lines
+23
to
+25
| object ServicePool { | ||
| val authService = ApiFactory.create<AuthService>() | ||
| } |
| @@ -1,4 +1,4 @@ | |||
| package com.sopt.now.compose.home | |||
| package com.sopt.now.compose.main.home | |||
There was a problem hiding this comment.
main 이라는 package 명을 보면 동료개발자가 해당 패키지에 어떤 class들이 들어있는지 알 수 있을까요??
| import retrofit2.http.POST | ||
|
|
||
| interface AuthService { | ||
| @POST("member/join") //http 메소드 |
| @POST("member/join") //http 메소드 | ||
| fun signUp( | ||
| @Body request: RequestSignUpDto | ||
| ): Call<ResponseSignUpDto> //비동기->callback |
junseo511
approved these changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue 🛠
Work Description ✏️
Screenshot 📸
Uncompleted Tasks 😅
To Reviewers 📢
늦었지만,, 빠르게 달려보겠습니다..ㅠ