FEAT #6
Open
FEAT #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0se0
reviewed
May 5, 2024
Comment on lines
+37
to
+39
| viewBinding{ | ||
| enabled = true | ||
| } |
There was a problem hiding this comment.
buildFeatures 내에서 viewBinding 활성화 시켜주셔서 삭제해도 될 거 같아요!
Comment on lines
+17
to
+20
| @POST("member/login") | ||
| fun login( | ||
| @Body request: RequestLoginDto | ||
| ): Call<ResponseLoginDto> |
Comment on lines
+20
to
+38
| binding.btnSignup.setOnClickListener { | ||
| val intent = Intent(this, SignupActivity::class.java) | ||
| startActivity(intent) | ||
| } | ||
| binding.btnLogin.setOnClickListener { | ||
| val id = binding.etId.text.toString() | ||
| val password = binding.etPassword.text.toString() | ||
| val requestLoginDto = RequestLoginDto( | ||
| authenticationId = id, | ||
| password = password | ||
| ) | ||
| authService.login(requestLoginDto).enqueue(object : Callback<ResponseLoginDto> { | ||
| override fun onResponse( | ||
| call: Call<ResponseLoginDto>, | ||
| response: Response<ResponseLoginDto>, | ||
| ) { | ||
| if (response.isSuccessful) { | ||
| val loginResponse = response.body() | ||
| if (loginResponse?.code == 200) { |
Comment on lines
+73
to
+81
| if (!isPassword(password)) { | ||
| Toast.makeText(this@SignupActivity, "비밀번호는 8자 이상이어야 하며, 숫자, 문자, 특수문자를 포함해야 합니다.", Toast.LENGTH_SHORT).show() | ||
| return null | ||
| } | ||
|
|
||
| if (!isPhone(phoneNumber)) { | ||
| Toast.makeText(this@SignupActivity, "전화번호 형식이 올바르지 않습니다. (예: 010-0000-0000)", Toast.LENGTH_SHORT).show() | ||
| return null | ||
| } |
There was a problem hiding this comment.
위에서 "회원가입 실패 $errorC , $errorM", 이렇게 에러메세지를 출력해주고 있어서 이 부분은 지워주셔도 될 거 같아요!
|
고생하셨습니다! |
t1nm1ksun
reviewed
May 7, 2024
| import kotlinx.serialization.Serializable | ||
|
|
||
| @Serializable | ||
| data class ResponseChangePasswordDto( |
There was a problem hiding this comment.
다른분들 코드보고 저도 제 코드 고쳤는데 똑같은 구조를 가진 Response dat class들은 하나로 통일시켜서 사용해도 될 것 같아요!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
시연 영상
xml.mp4
viewmodel 적용되어있습니다