Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Produce an informative declaration error, #24 #25

Merged
merged 1 commit into from
Jul 3, 2024
Merged

Conversation

james-d-brown
Copy link
Collaborator

Description

When encountering an invalid time zone offset, produce a more informative error and ensure that declaration validation encapsulates the error with a status event, rather than an exception.

Changes Made

Testing

Related Tickets

  • Fixes [Ticket number]

Checklists

Deployment Plan (For developer use)

How does the changes affect the product?

  • Feature addition
  • Bug fix
  • Database change

Issuer Checklist (For developer use)

You may update this checklist before and/or after creating the PR. If you're unsure about any of them, please ask, we're here to help! These items are what we are going to look for before merging your code.

  • Informative and human-readable title, using the format: [_pt] PR: <description>
  • Links are provided if this PR resolves an issue, or depends on another other PR
  • The feature branch you're submitting as a PR is up to date
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • No Placeholder code
  • Reviewers requested
  • Add yourself as an assignee in the PR

Merge Checklist (For Technical Lead use only)

  • If applicable, update README with major alterations

…tive error and ensure that declaration validation encapsulates the error with a status event, rather than an exception, #24.
@james-d-brown james-d-brown self-assigned this Jul 3, 2024
@james-d-brown james-d-brown added this to the v6.25 milestone Jul 3, 2024
@james-d-brown james-d-brown merged commit a802b0a into master Jul 3, 2024
3 checks passed
@james-d-brown james-d-brown deleted the issue24 branch July 3, 2024 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant