Update for compatibility with (at least) hydrofabric 2.1 #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most changes were made by Scott locally, but I am committing them myself
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scott and I made changes to allow TopoFlow to be compatible with newer versions of the hydrofabric. In particular, we tested hydrofabric version 2.1 data in the catchment with USGS gauge 01073000.
The How_to_Run_TopoFlow_in_NextGen.txt was updated to provide instructions for running TopoFlow for a NextGen catchment outside of the ngen framework (runs inside the framework still to be tested; pending regular grid support in the framework) using the associated code changes in this PR.
Example data for running the test case in this document was added to the topoflow/examples folder.
*Note: this PR also includes some repo formatting commits from PR #4, which is under review