Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename nc-config to nf-config for the reservoir module #677

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

HuidaeCho
Copy link

@HuidaeCho HuidaeCho commented Nov 1, 2023

Since NetCDF 4.9.2, nc-config --fflags and nc-config --flibs are removed. This PR fixes "unknown option: --fflags Usage: nc-config" by renaming nc-config to nf-config in src/kernel/reservoir/makefile.

Additions

Removals

Changes

  • Rename nc-config to nf-config in src/kernel/reservoir/makefile.

Testing

  1. Without this PR, ./compile.sh fails with an "unknown option: --fflags Usage: nc-config ..." error because nc-config doesn't support --fflags and --flibs anymore since Update nc-config Unidata/netcdf-c#2619 (netcdf-4.9.2).
  2. With this PR, the reservoir makefile calls nf-config from netcdf-fortran.

Screenshots

Notes

Todos

Checklist

  • PR has an informative and human-readable title
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows project standards (link if applicable)
  • Passes all existing automated tests
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future todos are captured in comments
  • Visually tested in supported browsers and devices (see checklist below 👇)
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
  • Reviewers requested with the Reviewers tool ➡️

Testing checklist

Target Environment support

  • Windows
  • Linux
  • Browser

Accessibility

  • Keyboard friendly
  • Screen reader friendly

Other

  • Is useable without CSS
  • Is useable without JS
  • Flexible from small to large screens
  • No linting errors or warnings
  • JavaScript tests are passing

@HuidaeCho HuidaeCho changed the title Rename nc-config to nf-config Rename nc-config to nf-config for the reservoir module Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant