BMI prototype for Hyfeature network #598
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
groutr
reviewed
Dec 9, 2022
|
|
||
| # -------------- Initalize all the variables --------------------------# | ||
| # -------------- so that they'll be picked up with the get functions --# | ||
| for var_name in list(self._var_name_units_map.keys()): |
There was a problem hiding this comment.
Creating a list here is unnecessary. The keys can be iterated thru directly.
for var_name in self._var_nname_units_map:
groutr
reviewed
Dec 9, 2022
| int | ||
| Rank of grid. | ||
| """ | ||
| return len(self._model.shape) |
There was a problem hiding this comment.
If self._model is a numpy array, we can simply return self._model.ndim
groutr
reviewed
Dec 9, 2022
| int | ||
| Size of grid. | ||
| """ | ||
| return int(np.prod(self._model.shape)) |
There was a problem hiding this comment.
If self._model is a numpy array, we can return self._model.size
groutr
reviewed
Dec 9, 2022
| return self._name | ||
|
|
||
| def get_input_item_count(self): | ||
| """Get names of input variables.""" |
There was a problem hiding this comment.
Docstring doesn't make sense here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A prototype of wrapping BMI around t-route with Hyfeature networks is produced here. So far, BMI around initialize and set_value functions were successfully made. The initialize function prepares channel network connectivity and config file parameter values. Also, it prepares sets of forcing files and sets of TimeSlice files for each time loop and sets of CHRTOUT files against which to compare t-route flows. Finally, it coverts lateral flow dataframe into one element of BMI dictionary data.
** This is only a prototype (not to be merged yet) and more updates yet to come.
Additions
Removals
Changes
Testing
python3 run-troute-with-bmi.py
Screenshots
Notes
Todos
Checklist
Testing checklist
Target Environment support
Accessibility
Other