Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initial refactoring of main from ngen #578

Draft
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

shorvath-noaa
Copy link
Contributor

Initial refactoring of main only incorporating edits from the ngen branch. Functionality has been added to current implementation rather than overwriting existing functions.

Next steps are to incorporate more recent changes in main branch main.py into ngen implementation. Start with addressing input parameters to compute_nhd_routing_v02 within _run_everything_v02 function in main.py

Additions

  • importing abstract networks in main.py
  • added functions _handle_args_v02, main_v02, _run_everything_v02, to main.py
  • added function _input_handler_v02 to input.py
  • added function set_supernetwork_parameters to nhd_network_utilities_v02.py

Removals

Changes

Testing

Screenshots

Notes

Todos

Checklist

  • PR has an informative and human-readable title
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows project standards (link if applicable)
  • Passes all existing automated tests
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future todos are captured in comments
  • Visually tested in supported browsers and devices (see checklist below 👇)
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
  • Reviewers requested with the Reviewers tool ➡️

Testing checklist

Target Environment support

  • Windows
  • Linux
  • Browser

Accessibility

  • Keyboard friendly
  • Screen reader friendly

Other

  • Is useable without CSS
  • Is useable without JS
  • Flexible from small to large screens
  • No linting errors or warnings
  • JavaScript tests are passing

@shorvath-noaa
Copy link
Contributor Author

@kumdonoaa

@shorvath-noaa shorvath-noaa mentioned this pull request Aug 31, 2022
21 tasks
@shorvath-noaa
Copy link
Contributor Author

@hellkite500 @mattw-nws This has been edited to work with PR#579 (new DA class object) and PR#584 (NHDNetwork class). Will need to merge those two PRs to test this out. New main function is main_v04.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant