Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update both BMI C++ header copies to reflect virtual destructor #832

Merged

Conversation

PhilMiller
Copy link
Contributor

@PhilMiller PhilMiller commented Jun 10, 2024

Addresses the model engine element of #831.

These PRs need to be merged in tandem:

Changes

  • Modify the declaration to virtual ~Bmi()
  • Update the submodule copy of the reference bmi-cxx/bmi.hxx to match upstream

Testing

  1. Local CI
  2. CI of SloTH, SMP, SFT, and LGAR-C, modified to cross-reference each others' updates

Notes

  • All of the supported modules are going to have to make the switch in a somewhat coordinated fashion. This PR should perhaps encompass updating the submodule versions of any such that are affected, to make an atomic step forward.

Checklist

  • PR has an informative and human-readable title
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows project standards (link if applicable)
  • Passes all existing automated tests
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future todos are captured in comments
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
  • Reviewers requested with the Reviewers tool ➡️

@PhilMiller PhilMiller linked an issue Jun 11, 2024 that may be closed by this pull request
3 tasks
Copy link
Member

@hellkite500 hellkite500 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Routing test failure is unrelated and will be addressed separately.

@hellkite500 hellkite500 merged commit 84d71ea into NOAA-OWP:master Jun 11, 2024
18 of 19 checks passed
@PhilMiller PhilMiller deleted the PhilMiller/bmi-wnon-virtual-dtor branch June 11, 2024 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update all C++ BMI modules to reference virtual destructor
2 participants