Refactor get_available_variable_names to return a span<string> rather than a concrete vector<string> #644
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows implementations to vary how they store and provide the available names (to some extent), potentially cutting memory overhead.
Changes
DataProvider
interface and all implementations to returnspan<string>
auto
at call sites, since they uniformly don't actually care that they've gotten a vector, as opposed to afind()
-able collectionNotes
Checklist