Remove custom time unit conversion in favor of UDUNITS

[stcui007]

Replace acquire_time_conversion_factor() function with get_time_convert_factor() function using UnitsHelper.

Additions

Removals

Changes

To comply with BMI standard, the function acquire_time_conversion_factor() defined Bmi_Adapter.hpp is removed and replaced with the function get_time_convert_factor() which returns the bmi_model_time_convert_factor used in a number of code files listed below. This is faciliated by BMI interface and UnitsHelper functions.

include/realizations/catchment/Bmi_Adapter.hpp
include/realizations/catchment/Bmi_Fortran_Adapter.hpp
src/realizations/catchment/Bmi_C_Adapter.cpp
src/realizations/catchment/Bmi_Cpp_Adapter.cpp
src/realizations/catchment/Bmi_Py_Adapter.cpp

Testing

Run ngen test

Screenshots

Notes

Todos

Checklist

• PR has an informative and human-readable title
• Changes are limited to a single goal (no scope creep)
• Code can be automatically merged (no conflicts)
• Code follows project standards (link if applicable)
• Passes all existing automated tests
• Any change in functionality is tested
• New functions are documented (with a description, list of inputs, and expected output)
• Placeholder code is flagged / future todos are captured in comments
• Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
• Reviewers requested with the Reviewers tool ➡️

Testing checklist (automated report can be put here)

Target Environment support

• Linux

[PhilMiller]

Once these are improved, I'm happy to approve this:

• Please use the Changes section of the PR notes to describe the changes, not to just list out files (since Git can tell us what files changed anyway), and fix the checklist formatting.
• Please fix the marked typo

[stcui007]

Thanks for the careful checking, Phil. Will do.