Summa initial NGen contribution #513
Open
+391
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing submodule branch that works for all builds too. Eventually this will be the master branch
* commit '90f6fc9bfa742f63b3d9194843527169b6a0664c': (307 commits) Replace unused boost/bind.hpp that was generating warnings with std's <functional> NullForcingProvider: Drop now-unnecessary private empty vector Add missing 'override' annotation Refactor get_available_variable_names to return a span<string> rather than a concrete vector<string> Cleanup from review feedback Removed requirement for `"path"` in forcing config Adjusted example file to use no new models or capabilities Delete a redundant code line Revise Bmi_Multi_Formulation and remove some include headers from NullForcingProvider Remove unused include header names Remove presetting available forcings Remove is_param_sum_over_time_step function. Revised NullForcingProvider incorporating Matt's comments Revise config jason to be force-less. Null/Constant Forcing Provider cmake: default python support to ON Another couple typos Random typo fix Remove commented-out code Remove dead code ...
* commit '72f121a5d12762d59c3870efd6d0598f2286886c': Fix a CMakelist.txt error. Add unit test for logging and other revisions Implement a logging function cmake: set NetCDF support to default to OFF Update test routing config to alleviate pydantic errors (NOAA-OWP#654)
* upstream/master: (193 commits) Routing test: Minor cleanups Drop 'using std::shared_ptr' from high-level header Fix all instances of typo recieve Fix all instances of typo interperter Typo fix Remove scalar overload of get_var_value_as_double Refactor Bmi_Formulation: Share duplicate implementations of scalar get_var_value_as_double Refactor: consolidate duplicate implementations into Bmi_Module_Formulation::get_response Bmi_Formulation: Share single copies of required and optional configuration parameter vectors Make non-overridden protected member functions non-virtual Refactor: Move virtual get_output_line_for_timestep from Formulation to Catchment_Formulation Refactor: Move virtual get_output_header_line from Formulation to Catchment_Formulation Refactor: Move virtual get_response from Formulation to Catchment_Formulation Test: Specify Catchment_Formulation when iterating over (catchment) Formulation_Manager entities Delete never-used Nexus_Manager code that uses class Formulation unexpectedly Incorporate reviwer's suggestions Add total time to the tables Update documentation Realization configs and routing config for ngen with routing fix(bmi): re-throw exceptions as std::runtime_error with original error message when getting time conversions ... # Conflicts: # .gitmodules # extern/pybind11
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Short description explaining the high-level reason for the pull request]
@jameshalgren
Additions
Removals
Changes
Testing
cmake_build/ngen data/catchment_data.geojson "celia" ./data/nexus_data.geojson "nex-26" ./extern/summa/summa/test_ngen/example_realization_config_w_summa_bmi.json
or
cmake_build/ngen data/catchment_data.geojson "cat-27" ./data/nexus_data.geojson "nex-26" ./extern/summa/summa/test_ngen/example_realization_config_w_summa_bmi__mac.json
This command can be run as ./extern/summa/summa/test_ngen/example_run_celia.[system_type].sh also.
Screenshots
Notes
Todos
Checklist
Testing checklist (automated report can be put here)
Target Environment support