Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes terraform issues missed during model_version refactor #952

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

shawncrawley
Copy link
Collaborator

Refs #824

It's tough to commit perfect code as per terraform since I personally don't yet have the full permissions a terraform deployment. This fixes a few of the bugs from PR #949 that slipped past me and were found by @DrixTabligan-NOAA while deploying it to TI.

@DrixTabligan-NOAA DrixTabligan-NOAA merged commit d698160 into ti Nov 12, 2024
1 check passed
@shawncrawley shawncrawley deleted the ti-terraform-fixes branch November 12, 2024 21:18
@nickchadwick-noaa nickchadwick-noaa added this to the V2.1.8 milestone Jan 8, 2025
@nickchadwick-noaa nickchadwick-noaa linked an issue Jan 8, 2025 that may be closed by this pull request
5 tasks
@nickchadwick-noaa nickchadwick-noaa restored the ti-terraform-fixes branch January 8, 2025 16:38
@nickchadwick-noaa nickchadwick-noaa deleted the ti-terraform-fixes branch January 28, 2025 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add new "model_version" field to all inundation services/sublayers
3 participants