RnR Domain Hotfix #596
Merged
RnR Domain Hotfix #596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refs #594. On the RnR side, thresholds are prioritized as 1) native, 2) usgs, and 3) nrldb. On the viz-side, however, these were being prioritized as 1) usgs, 2) nrldb, and 3) native. This was causing mismatched thresholds between processing and visualizing, and thus preventing certain sites from being categorized as flooding and also being mapped for FIM.
Refs #594 Both streamflow and stage forecasts are pulled into RnR by converting the stage forecasts to flow with a rating curve. Some sites only have official thresholds defined using stage. On the visualization side, these stage-threshold-only forecasts were getting labeled with a status of "All thresholds missing" since only flow thresholds were being compared against the flows. Thus, this commit adds the fix of converting the max RnR flow values back to stage using their rating curve, if available, and then using this converted value to compare to the stage thresholds if those are what is available. This assigns the correct and expected status (i.e. Action, Minor, Moderate, Major) to the reaches and produces FIM for them when necessary.
nickchadwick-noaa
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR applies various fixes that were underlying the issues discussed in ticket #594. Basically, there were some shortcomings in the RnR processing SQL files that were either leaving sites out or wrongly categorizing them. These issues have been fixed.