Adds pagination to viz cache archiving script #586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TylerSchrag-NOAA
approved these changes
Nov 14, 2023
nickchadwick-noaa
pushed a commit
that referenced
this pull request
Feb 21, 2024
The boto3 S3 client function `list_objects_v2` has a max result count of 1000 objects. There are more objects than this in many of the `viz_cache` folders that are being searched and we've already had one case of matching objects being missed because they weren't included in that 1000 results. This PR replaces the basic `list_objects_v2` function with a paginator-wrapped version that will continue grabbing 1000 object batches until they all have been checked.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The boto3 S3 client function
list_objects_v2has a max result count of 1000 objects. There are more objects than this in many of theviz_cachefolders that are being searched and we've already had one case of matching objects being missed because they weren't included in that 1000 results. This PR replaces the basiclist_objects_v2function with a paginator-wrapped version that will continue grabbing 1000 object batches until they all have been checked.