Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tag = {} for all aws_s3_objects #1003

Merged
merged 5 commits into from
Dec 4, 2024
Merged

tag = {} for all aws_s3_objects #1003

merged 5 commits into from
Dec 4, 2024

Conversation

EdisonOrellana-NOAA
Copy link
Contributor

Why

This is to fix deployment errors with s3 objects having >10 tags which is not allowed.

Additions

  • tags = {}

Screenshots

I did a really cool regex find and replace:
amazing-regex

Notes

Drix encountered this error:


│ Error: error updating tags: error setting resource tags (hydrovis-ti-deployment-us-east-1/terraform_artifacts/EC2/Ingest/owp-hml-ingester.tar.gz): BadRequest: Object tags cannot be greater than 10
│       status code: 400, request id: PA30P15KR8DPBNXN, host id: HI7YPFc9BOOKetco+P8fLEvb1p/0WS+vXX8U8+w9qBZgyKPFZrSxSnPYNRnsrWwC4amexhSkdQk=
│ 
│   with module.data-ingest-ec2.aws_s3_object.hml_ingester,
│   on EC2/Ingest/[main.tf](http://main.tf/) line 86, in resource "aws_s3_object" "hml_ingester":
│   86: resource "aws_s3_object" "hml_ingester" {
│ 

This is to fix errors with s3 objects having >10 tags which is not allowed.
@EdisonOrellana-NOAA
Copy link
Contributor Author

Implemented this solution to this problem

@EdisonOrellana-NOAA
Copy link
Contributor Author

@DrixTabligan-NOAA Hopefully this should do it. I think I hit all the necessary modules in Core\main.tf. We'll see

@EdisonOrellana-NOAA
Copy link
Contributor Author

Hi Drix, I checked a handful of EC2s and some objects on S3. Both were tagged correctly. Willing to go ahead with merge. Can look at it tomorrow (12/04)

Copy link
Collaborator

@DrixTabligan-NOAA DrixTabligan-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and have been tested and confirmed working. Merging into TI now.

@DrixTabligan-NOAA DrixTabligan-NOAA merged commit dadf9ef into ti Dec 4, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority - High Priority Level Task 2 GAMA Task 2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants