Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bugs in setting GxSpV_u and GxSpV_v in MOM_isopycnal_slopes #701

Merged
merged 2 commits into from
Aug 2, 2024

Conversation

Wendazhang33
Copy link

  • In the previous version, GxSpV_u and GxSpV_v were only set when use_EOS was true
  • Now initialize GxSpV_u and GxSpV_v to be G_Rho0

@Wendazhang33 Wendazhang33 force-pushed the GxSpV_fix branch 2 times, most recently from cc14f9e to 828e1a0 Compare August 1, 2024 22:19
Copy link

codecov bot commented Aug 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 35.87%. Comparing base (90749f3) to head (828e1a0).
Report is 2 commits behind head on dev/gfdl.

Additional details and impacted files
@@             Coverage Diff              @@
##           dev/gfdl     #701      +/-   ##
============================================
- Coverage     36.99%   35.87%   -1.13%     
============================================
  Files           272      269       -3     
  Lines         82438    81375    -1063     
  Branches      15421    15406      -15     
============================================
- Hits          30500    29195    -1305     
- Misses        46246    46438     +192     
- Partials       5692     5742      +50     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@Hallberg-NOAA Hallberg-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that these changes are correct and necessary.

 - In the previous version, GxSpV_u and GxSpV_v were only set when use_EOS was true
 - Now initialize GxSpV_u and GxSpV_v to be G_Rho0
@Hallberg-NOAA
Copy link
Member

This PR has passed pipeline testing at https://gitlab.gfdl.noaa.gov/ogrp/mom6ci/MOM6/-/pipelines/24333.

@Hallberg-NOAA Hallberg-NOAA merged commit e30a6e7 into NOAA-GFDL:dev/gfdl Aug 2, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants