Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes remap_via_sub_cells(), moving code into remapping_core_h() #693

Merged

Commits on Aug 1, 2024

  1. Removes remap_via_sub_cells(), after copying code into remapping_core…

    …_h()
    
    This commit addresses a `\todo` added in NOAA-GFDL#662, namely that
    the functions remap_via_sub_cells() and remap_via_sub_cells_om4() could,
    and should, be moved up into remapping_core_h(), as well as into the
    obsolete remapping_core_w().
    
    In that PR, the function remap_via_sub_cells() had been modularized into
    three other functions, and the near-duplicatem remap_via_sub_cells_om4(),
    called the two of the same functions as well as an out-of-date version of
    the third function.
    
    Since the reampping_core_h() function calls is already brief, calling one
    function in addition to remap_via_sub_cells(), and since
    remap_via_sub_cells() is only called from remapping_core_*(), we can remove
    a level of call-tree depth depth by copying remap_via_sub_grid() into
    reampping_core_h() and removing the unused function(s).
    adcroft authored and Hallberg-NOAA committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    3069058 View commit details
    Browse the repository at this point in the history