-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document surface obs xarray/nc format #346
Conversation
Question: should we also add something here about getting new obs data sources into the tool "officially"? (e.g. start by opening Issue or Discussion in MM repo) |
time_local is only really required if regulatory metrics are to be calculated. For anything else, the time variable to be used in the plot can be set in the YAML file.
This looks great. I would reserve the "officially" for the developer's guide, but if you prefer to add them here, I don't see a problem with that either. |
@blychs using |
Include mention of timeseries
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
adding mentions of timeseries
I'm ready to approve this PR once the one open conversation is closed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
I'm happy for this to get merged @rschwant |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree, looks good! @zmoon you can merge it when ready.
Thanks @blychs for the help |
No description provided.