Feature: rename observation coordinates for xarray datasets #330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colin-harkins
approved these changes
Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While testing if the existing aircraft tools would work for IAGOS observations I discovered that the existing rename_vars function in the obs class does not allow renaming of xarray coordinate variables through the yaml variables option. The IAGOS files are netcdf. When these are opened with xr.open_dataset lat, lon, time, and an altitude variable are assigned as coordinates. The coordinate names aren't the monetio standard names.
I was able to determine that for xarray datasets the 'data_vars' attribute does not include the names variables labeled as coordinates. This pull request adds the coordinate variable names (eg. lat, lon, time) to the data variable name list when the obs dataset is an xarray.Dataset.